From: Andrew Morton <akpm@linux-foundation.org>
To: Andy Whitcroft <apw@shadowen.org>
Cc: Harvey Harrison <harvey.harrison@gmail.com>,
Hugh Dickins <hugh@veritas.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm: hugetlb.c make functions static, use NULL rather than 0
Date: Fri, 29 Aug 2008 01:48:09 -0700 [thread overview]
Message-ID: <20080829014809.be6689f6.akpm@linux-foundation.org> (raw)
In-Reply-To: <20080829082950.GC3387@brain>
On Fri, 29 Aug 2008 09:29:50 +0100 Andy Whitcroft <apw@shadowen.org> wrote:
> On Mon, Aug 25, 2008 at 10:27:39AM +0100, Hugh Dickins wrote:
> > On Fri, 22 Aug 2008, Harvey Harrison wrote:
> >
> > > mm/hugetlb.c:265:17: warning: symbol 'resv_map_alloc' was not declared. Should it be static?
> > > mm/hugetlb.c:277:6: warning: symbol 'resv_map_release' was not declared. Should it be static?
> > > mm/hugetlb.c:292:9: warning: Using plain integer as NULL pointer
> > > mm/hugetlb.c:1750:5: warning: symbol 'unmap_ref_private' was not declared. Should it be static?
>
> Harvey are you using some additional compiler flags to get this, I am
> pretty sure I checked for warnings during compilation before this lot
> was merged. Hmmm.
sparse. `make C=1'
prev parent reply other threads:[~2008-08-29 8:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-22 22:47 [PATCH] mm: hugetlb.c make functions static, use NULL rather than 0 Harvey Harrison
2008-08-25 9:27 ` Hugh Dickins
2008-08-29 8:29 ` Andy Whitcroft
2008-08-29 8:48 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080829014809.be6689f6.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=apw@shadowen.org \
--cc=harvey.harrison@gmail.com \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox