Re: [PATCH 3/3] OLPC: touchpad driver (take 2)

Andres Salomon
2008-09-11T14:32:58Z

On Thu, 11 Sep 2008 09:05:22 -0400
Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:

> On Thu, Sep 11, 2008 at 01:32:09AM -0400, Andres Salomon wrote:
> >
> > And here's the current touchpad driver after updating based upon
> > your comments.
> >
>
> Looks good. Care to respin it all thogether based on the attribute
> change I requested so I can be sure I'm applying the latest version of
> everything? Ummm....
>

Thanks, will do.

> > diff --git a/drivers/input/mouse/Kconfig
> > b/drivers/input/mouse/Kconfig index 7bbea09..fff0253 100644
> > --- a/drivers/input/mouse/Kconfig
> > +++ b/drivers/input/mouse/Kconfig
> > @@ -96,6 +96,16 @@ config MOUSE_PS2_TOUCHKIT
> >
> > If unsure, say N.
> >
> > +config MOUSE_PS2_OLPC
> > + bool "OLPC PS/2 mouse protocol extension"
> > + depends on MOUSE_PS2 && OLPC
>
> Are you sure it shoudl depend on OLPC? It looks like driver should
> work on any box with PS/2 port. I understand that only OLPC has the
> hardware installed but can this change?
>
> Thanks!
>

Positive; the majority of this driver is just workarounds for bugs in
the hardware that are specific to OLPC. If we didn't have to
deal with flaky hardware and recalibrations, we could just
use standard psmouse without extensions. :/