From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754466AbYH2HsA (ORCPT ); Fri, 29 Aug 2008 03:48:00 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752833AbYH2Hrn (ORCPT ); Fri, 29 Aug 2008 03:47:43 -0400 Received: from pasmtpa.tele.dk ([80.160.77.114]:39910 "EHLO pasmtpA.tele.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752732AbYH2Hrn (ORCPT ); Fri, 29 Aug 2008 03:47:43 -0400 Date: Fri, 29 Aug 2008 09:47:39 +0200 From: Jens Axboe To: Neil Brown Cc: Andrew Morton , "Rafael J. Wysocki" , jurriaan , linux-kernel@vger.kernel.org Subject: Re: 2.6.27-rc4: lots of 'in_atomic():1, irqs_disabled():0' with software-raid1 Message-ID: <20080829074739.GN20055@kernel.dk> References: <20080827170538.GA24393@amd64.of.nowhere> <200808272347.43577.rjw@sisk.pl> <20080828073324.GR20055@kernel.dk> <20080828004532.45d8b8c9.akpm@linux-foundation.org> <20080828074830.GV20055@kernel.dk> <18614.24929.952454.829021@notabene.brown> <20080828020018.a8ea85f0.akpm@linux-foundation.org> <18615.42728.498883.440973@notabene.brown> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <18615.42728.498883.440973@notabene.brown> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 29 2008, Neil Brown wrote: > On Thursday August 28, akpm@linux-foundation.org wrote: > > > > I'm curious about how this happened. > > > > afaict from reading the code, this: > > > > rcu_read_lock(); > > might_sleep(); > > rcu_read_unlock(); > > > > will warn if CONFIG_PREEMPT_RCU=n but won't warn if > > CONFIG_PREEMPT_RCU=y. If correct, that's a nasty trap. > > > > Is that what you did? > > Uhm.. > $ grep PREEMPT /home/src/md-x86-64/.config > CONFIG_PREEMPT_NONE=y > # CONFIG_PREEMPT_VOLUNTARY is not set > # CONFIG_PREEMPT is not set > $ grep DEBUG_SPIN /home/src/md-x86-64/.config > CONFIG_DEBUG_SPINLOCK=y > CONFIG_DEBUG_SPINLOCK_SLEEP=y > $ grep RCU /home/src/md-x86-64/.config > CONFIG_CLASSIC_RCU=y > # CONFIG_RCU_TORTURE_TEST is not set > > This definitely doesn't report an error if I put "might_sleep" inside > rcu_read_lock. I tried to figure out why but got lost. :/ > BTW, I need the following to get current -git to compile. > > NeilBrown > > Author: NeilBrown > Date: Tue Aug 19 11:59:37 2008 +1000 > > Fix compile error in security > > diff --git a/include/linux/security.h b/include/linux/security.h > index 2ee5ecf..0cc23a1 100644 > --- a/include/linux/security.h > +++ b/include/linux/security.h > @@ -1757,7 +1757,7 @@ static inline int security_ptrace_may_access(struct task_struct *child, > > static inline int security_ptrace_traceme(struct task_struct *child) > { > - return cap_ptrace_traceme(parent); > + return cap_ptrace_traceme(child); > } > > static inline int security_capget(struct task_struct *target, That has been fixed in the tree for over a week, I think you need to update :-) -- Jens Axboe