Re: [PATCH 4/5] select: make select() use schedule_hrtimeout()

Linus Torvalds
2008-08-29T18:46:39Z

On Fri, 29 Aug 2008, Alan Cox wrote:
>
> Most of the timers we want to aggregate with are kernel originated and
> those also need accuracy fields (tcp retransmit is fairly precision at
> high speed while tcp keepalive is 'yeah whatever' sort of urgency.

Actually, I disagree.

They are _both_ of the exact same type: the precision depends on how long
the timeout is.

TCP retransmit timers are a perfect example. If the timeout is long (which
is quite common if you end up having multiple retransmits), you _really_
don't care about how precise it is.

And keepalives are 'yeah whatever' exactly because they are so long, not
because they are inherently uninteresting per se.

I suspect you could find some kernel-generated timer that doesn't fit that
pattern, but I can't really think of any.

> Agreed except that I'd assume real time tasks implied high accuracy,
> otherwise one assumes they'd have not have been real time - and probably
> putting those constants into sysfs somewhere.

And yes, I do agree that the heuristic could well involve other
characteristics of the process in question. And probably characteristics
of the machine itself (ie some general kind of "power mode" where timers
are simply not considered critical if you want to be in low-power mode).

Linus