Re: [PATCH 4/5] select: make select() use schedule_hrtimeout()

Daniel Walker
2008-08-29T16:24:22Z

On Fri, 2008-08-29 at 08:08 -0700, Arjan van de Ven wrote:
> rom: Arjan van de Ven <arjan@linux.intel.com>
> Date: Thu, 28 Aug 2008 13:45:38 -0700
> Subject: [PATCH] select: make select() use schedule_hrtimeout()
>
> now that we have schedule_hrtimeout(), make select() use it.
> But only for short delays; really long delays are assumed to not
> need the highres level of accuracy but rather want the regular
> timer behavior for now.
>
> This is only done for delays shorter than 1 second; currently
> the assumption is that longer delays have no desire to get the
> higher accuracy.

Do you have any basis to make this "short delays" assumption? I would
think if regular timers can be used for longer than a second, people
will naturally assume anything else that's high res will also ..

The futex_wait() has code which looks a lot like your
schedule_hrtimeout() , (you might want to replace your code there
instead) , and it doesn't seem to have the short delays restriction ..

Daniel