From: Andi Kleen <andi@firstfloor.org>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Andi Kleen <andi@firstfloor.org>,
paulmck@us.ibm.com, linux-kernel@vger.kernel.org, akpm@osdl.org
Subject: Re: [PATCH] Remove stop_machine during module load
Date: Mon, 1 Sep 2008 10:52:17 +0200 [thread overview]
Message-ID: <20080901085217.GA18288@one.firstfloor.org> (raw)
In-Reply-To: <200809011702.00956.rusty@rustcorp.com.au>
On Mon, Sep 01, 2008 at 05:02:00PM +1000, Rusty Russell wrote:
> On Saturday 30 August 2008 05:17:34 Andi Kleen wrote:
> > Remove stop_machine during module load
> >
> > module loading currently does a stop_machine on each module load to insert
> > the module into the global module lists. Especially on larger systems this
> > can be quite expensive.
>
> Thanks Andi, but doesn't this mean that we should be doing list_for_each_rcu
> in all the kallsyms readers?
Yes I did that in v2. But only for the ones that don't hold modules_mutex
anyways. Also I found that print_modules() does not always disable
preemption.
-Andi
--
ak@linux.intel.com
prev parent reply other threads:[~2008-09-01 8:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-29 19:17 [PATCH] Remove stop_machine during module load Andi Kleen
2008-08-29 20:44 ` Paul E. McKenney
2008-08-29 21:23 ` Andi Kleen
2008-08-29 22:07 ` Paul E. McKenney
2008-09-01 7:02 ` Rusty Russell
2008-09-01 8:52 ` Andi Kleen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080901085217.GA18288@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@us.ibm.com \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox