public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: linux-m68k@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: [patch 6/8] m68k: Define rtc_lock on Atari
Date: Wed, 03 Sep 2008 09:15:48 +0200	[thread overview]
Message-ID: <20080903071742.640740341@mail.of.borg> (raw)
In-Reply-To: 20080903071542.615137611@mail.of.borg

[-- Attachment #1: atari-define-rtc_lock.diff --]
[-- Type: text/plain, Size: 1156 bytes --]

From: Geert Uytterhoeven <geert@linux-m68k.org>

The nvram and rtc-cmos drivers use the spinlock rtc_lock to protect against
concurrent accesses to the CMOS memory. As m68k doesn't support SMP or preempt
yet, the spinlock calls tend to get optimized away, but not for all
configurations, causing in some rare cases:

| ERROR: "rtc_lock" [drivers/rtc/rtc-cmos.ko] undefined!
| ERROR: "rtc_lock" [drivers/char/nvram.ko] undefined!

Add the spinlock to the Atari core code to avoid this.

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
 arch/m68k/atari/time.c |    3 +++
 1 file changed, 3 insertions(+)

--- a/arch/m68k/atari/time.c
+++ b/arch/m68k/atari/time.c
@@ -20,6 +20,9 @@
 
 #include <asm/atariints.h>
 
+DEFINE_SPINLOCK(rtc_lock);
+EXPORT_SYMBOL_GPL(rtc_lock);
+
 void __init
 atari_sched_init(irq_handler_t timer_routine)
 {

-- 
Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds


  parent reply	other threads:[~2008-09-03  7:19 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-03  7:15 [patch 0/8] RFC: m68k patches for 2.6.28 Geert Uytterhoeven
2008-09-03  7:15 ` [patch 1/8] m68k: Use new printk() extension %pS to print symbols Geert Uytterhoeven
2008-09-03  7:15 ` [patch 2/8] m68k: Reverse platform MMU logic so Sun 3 is last Geert Uytterhoeven
2008-09-03  7:36   ` Adrian Bunk
2008-09-03 11:13     ` Laurent Vivier
2008-09-03 12:07       ` Adrian Bunk
2008-09-05 17:34         ` Riccardo
2008-09-03 18:10       ` Brad Boyer
2008-09-05 17:36         ` Riccardo
2008-09-23 21:47       ` Lance Tagliapietra
2008-09-03 19:22     ` Geert Uytterhoeven
2008-09-03  7:15 ` [patch 3/8] m68k: Disable Amiga serial console support if modular Geert Uytterhoeven
2008-09-03  7:15 ` [patch 4/8] m68k: Modular Amiga keyboard needs key_maps Geert Uytterhoeven
2008-09-03  7:15 ` [patch 5/8] m68k: Remove unused atari_kbd_translate() Geert Uytterhoeven
2008-09-04  9:32   ` Michael Schmitz
2008-09-04  9:39     ` Geert Uytterhoeven
2008-09-04  9:49   ` Michael Schmitz
2008-09-03  7:15 ` Geert Uytterhoeven [this message]
2008-09-04  9:51   ` [patch 6/8] m68k: Define rtc_lock on Atari Michael Schmitz
2008-09-03  7:15 ` [patch 7/8] m68k: Add missing dma_sync_single_range_for_{cpu,device}() Geert Uytterhoeven
2008-09-03 10:59   ` Roman Zippel
2008-09-03 11:17     ` [patch 7/8] m68k: Add missing dma_sync_single_range_for_{cpu, device}() Geert Uytterhoeven
2008-09-03 11:22       ` Geert Uytterhoeven
2008-09-03 11:39         ` Roman Zippel
2008-09-03 12:12     ` [patch 7/8] m68k: Add missing dma_sync_single_range_for_{cpu,device}() Adrian Bunk
2008-09-03 12:36       ` Roman Zippel
2008-09-03  7:15 ` [patch 8/8] m68k: <asm/pci.h> needs <asm-generic/pci-dma-compat.h> Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080903071742.640740341@mail.of.borg \
    --to=geert@linux-m68k.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m68k@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox