From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755803AbYICOGu (ORCPT ); Wed, 3 Sep 2008 10:06:50 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754011AbYICOGk (ORCPT ); Wed, 3 Sep 2008 10:06:40 -0400 Received: from bohort.kerlabs.com ([62.160.40.57]:37858 "EHLO bohort.kerlabs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753995AbYICOGj (ORCPT ); Wed, 3 Sep 2008 10:06:39 -0400 Date: Wed, 3 Sep 2008 16:06:37 +0200 From: Louis Rilling To: Andrey Mirkin Cc: containers@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/9] OpenVZ kernel based checkpointing/restart Message-ID: <20080903140636.GS14473@hawkmoon.kerlabs.com> Reply-To: Louis.Rilling@kerlabs.com References: <1220439476-16465-1-git-send-email-major@openvz.org> <20080903134951.GQ14473@hawkmoon.kerlabs.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=_bohort-23377-1220450664-0001-2" Content-Disposition: inline In-Reply-To: <20080903134951.GQ14473@hawkmoon.kerlabs.com> User-Agent: Mutt/1.5.17+20080114 (2008-01-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is a MIME-formatted message. If you see this text it means that your E-mail software does not support MIME-formatted messages. --=_bohort-23377-1220450664-0001-2 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Sep 03, 2008 at 03:49:51PM +0200, Louis Rilling wrote: > On Wed, Sep 03, 2008 at 02:57:47PM +0400, Andrey Mirkin wrote: > > This patchset introduces kernel based checkpointing/restart as it is > > implemented in OpenVZ project. This patchset has limited functionality = and > > are able to checkpoint/restart only single process. Recently Oren Laaden > > sent another kernel based implementation of checkpoint/restart. The main > > differences between this patchset and Oren's patchset are: > >=20 > > * In this patchset checkpointing initiated not from the process > > (right now we do not have a container, only namespaces), Oren's patchset > > performs checkpointing from the process context. > >=20 > > * Restart in this patchset is initiated from process, which restarts a = new > > process (in new namespaces) with saved state. Oren's patchset uses the = same > > process from which restart was initiated and restore saved state over i= t. > >=20 > > * Checkpoint/restart functionality in this patchset is implemented as a= kernel > > module > >=20 > >=20 > > As checkpointing is initiated not from the process which state should b= e saved > > we should freeze a process before saving its state. Right now Container= Freezer > > from Matt Helsley can be used for this. > >=20 > > This patchset introduce only a concept how kernel based checkpointing/r= estart > > can be implemented and are able to checkpoint/restart only a single pro= cess > > with simple VMAs.=20 > >=20 > > I've tried to split my patchset in small patches to make review more ea= sier. >=20 > Thank you Andrey for having highlighted the differences with Oren's appro= ach, > and for having split this patchset. Few remarks in reply to the patches. Forgot a global comment: you will probably get the same (rather pointless f= or a proof of concept, IMHO) requests as Oren got, to 1) improve coding style: a) especially avoid error handling like: err =3D foo(); if (!err) err =3D bar(); if (!err) err =3D baz(); and prefer err =3D foo(); if (err) goto foo_err; err =3D bar(); ... b) do not write conditions on a single line, like if (foo) bar; 2) put arch-dependent code in arch/ subdirs. 3) I probably forgot other ones. I obviously do not personally request you to take these requests into accou= nt ;) Louis --=20 Dr Louis Rilling Kerlabs Skype: louis.rilling Batiment Germanium Phone: (+33|0) 6 80 89 08 23 80 avenue des Buttes de Coesmes http://www.kerlabs.com/ 35700 Rennes --=_bohort-23377-1220450664-0001-2 Content-Type: application/pgp-signature; name="signature.asc" Content-Transfer-Encoding: 7bit Content-Description: Digital signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) iD8DBQFIvpnsVKcRuvQ9Q1QRAnQJAKC2vogLofoKerkTyX9yaCaVvJuCCQCg1div B8t2T2Yk5aewPhF+QA+qOjU= =Zd4q -----END PGP SIGNATURE----- --=_bohort-23377-1220450664-0001-2--