public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Matt Mackall <mpm@selenic.com>
Cc: aaron@merfinllc.com, linux-kernel@vger.kernel.org, tytso@mit.edu,
	stable@kernel.org
Subject: Re: drivers/char/random.c line 728 BUG
Date: Wed, 3 Sep 2008 16:12:48 -0700	[thread overview]
Message-ID: <20080903161248.6f7ee1ff.akpm@linux-foundation.org> (raw)
In-Reply-To: <1220482297.17608.84.camel@calx>

On Wed, 03 Sep 2008 17:51:37 -0500
Matt Mackall <mpm@selenic.com> wrote:

> Here's a more expansive version:
> 
> ___Avoid checking lock-protected entropy_count when lock isn't held. This
> fixes a bug reported by and diagnosed by Aaron Straus.
> 
> This fixes a regression introduced into 2.6.26 by
>  
>      commit adc782dae6c4c0f6fb679a48a544cfbcd79ae3dc
>      Author: Matt Mackall <mpm@selenic.com>
>      Date:   Tue Apr 29 01:03:07 2008 -0700
>  
>          random: simplify and rename credit_entropy_store

That regression already got fixed, and the fix is now in mainline and
is queued for 2.6.26.x.  So we would need a new rationale, please.


      reply	other threads:[~2008-09-03 23:13 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-26 22:59 drivers/char/random.c line 728 BUG Aaron Straus
2008-08-28 22:59 ` Aaron Straus
2008-08-29 19:48   ` Andrew Morton
2008-08-29 19:54     ` Andrew Morton
2008-08-29 22:31     ` Aaron Straus
2008-08-29 22:42       ` Andrew Morton
2008-09-03 18:18     ` Matt Mackall
2008-09-03 18:28       ` Aaron Straus
2008-09-03 22:12         ` Matt Mackall
2008-09-03 22:32           ` Andrew Morton
2008-09-03 22:51             ` Matt Mackall
2008-09-03 23:12               ` Andrew Morton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080903161248.6f7ee1ff.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=aaron@merfinllc.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mpm@selenic.com \
    --cc=stable@kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox