* [patch] block: Minor comment fix
@ 2008-09-03 22:15 Geoff Levand
2008-09-04 6:52 ` Jens Axboe
0 siblings, 1 reply; 2+ messages in thread
From: Geoff Levand @ 2008-09-03 22:15 UTC (permalink / raw)
To: axboe; +Cc: linux-kernel, Geert Uytterhoeven
Minor fix to the inline documentation of blk_release_queue().
Signed-off-by: Geoff Levand <geoffrey.levand@am.sony.com>
---
Hi Jens,
Seems like this comment is in error.
-Geoff
block/blk-sysfs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- a/block/blk-sysfs.c
+++ b/block/blk-sysfs.c
@@ -245,27 +245,27 @@ queue_attr_store(struct kobject *kobj, s
mutex_lock(&q->sysfs_lock);
if (test_bit(QUEUE_FLAG_DEAD, &q->queue_flags)) {
mutex_unlock(&q->sysfs_lock);
return -ENOENT;
}
res = entry->store(q, page, length);
mutex_unlock(&q->sysfs_lock);
return res;
}
/**
- * blk_cleanup_queue: - release a &struct request_queue when it is no longer needed
+ * blk_release_queue: - release a &struct request_queue when it is no longer needed
* @kobj: the kobj belonging of the request queue to be released
*
* Description:
- * blk_cleanup_queue is the pair to blk_init_queue() or
+ * blk_release_queue is the pair to blk_init_queue() or
* blk_queue_make_request(). It should be called when a request queue is
* being released; typically when a block device is being de-registered.
* Currently, its primary task it to free all the &struct request
* structures that were allocated to the queue and the queue itself.
*
* Caveat:
* Hopefully the low level driver will have finished any
* outstanding requests first...
**/
static void blk_release_queue(struct kobject *kobj)
{
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [patch] block: Minor comment fix
2008-09-03 22:15 [patch] block: Minor comment fix Geoff Levand
@ 2008-09-04 6:52 ` Jens Axboe
0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2008-09-04 6:52 UTC (permalink / raw)
To: Geoff Levand; +Cc: linux-kernel, Geert Uytterhoeven
On Wed, Sep 03 2008, Geoff Levand wrote:
> Minor fix to the inline documentation of blk_release_queue().
Well, yes and know. If you notice, it's actually not an exported
function. Moving the documentation to blk_cleanup_queue() would be the
right thing to do, with an added explanation on how blk_release_queue()
actually does the real work once all references to the device has gone
away.
--
Jens Axboe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-09-04 6:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-09-03 22:15 [patch] block: Minor comment fix Geoff Levand
2008-09-04 6:52 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox