From: Andi Kleen <andi@firstfloor.org>
To: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Cc: andi@firstfloor.org, joerg.roedel@amd.com, mingo@redhat.com,
tglx@linutronix.de, hpa@zytor.com, linux-kernel@vger.kernel.org,
iommu@lists.linux-foundation.org, kamezawa.hiroyu@jp.fujitsu.com,
tony.luck@intel.com
Subject: Re: [PATCH] swiotlb: fix dma_alloc_coherent allocation failures with swiotlb
Date: Thu, 4 Sep 2008 09:44:41 +0200 [thread overview]
Message-ID: <20080904074441.GY18288@one.firstfloor.org> (raw)
In-Reply-To: <20080904131130E.fujita.tomonori@lab.ntt.co.jp>
On Thu, Sep 04, 2008 at 01:11:47PM +0900, FUJITA Tomonori wrote:
> On Thu, 04 Sep 2008 00:09:51 +0200
> Andi Kleen <andi@firstfloor.org> wrote:
>
> > Joerg Roedel <joerg.roedel@amd.com> writes:
> >
> > > The SWIOTLB version of dma_alloc_coherent allocates all memory with
> > > GFP_DMA unconditionally. This leads sometimes unnecessary to allocation
> > > failures. This patch makes the allocation strategy to use the DMA32 zone
> > > first if this is possible. The changes are boot tested on AMD64 and
> > > compile tested for i386 and IA64.
> >
> > The high level dma_alloc_coherent() does that anyways.
>
> The high level dma_alloc_coherent means the tricks in
> arch/x86/pci-dma.c? If so, all the tricks has gone in tip/master.
Seems wrong -- that is something that is needed by multiple
IOMMUs. Pretty much all which work with real memory instead
of virtual mappings.
I also have an older swiotlb rewrite in the pipeline based on the DMA
allocator. The project got a little sidelined, but I hope to eventually
forward port it again.
-Andi
--
ak@linux.intel.com
next prev parent reply other threads:[~2008-09-04 7:41 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-03 15:03 [PATCH] swiotlb: fix dma_alloc_coherent allocation failures with swiotlb Joerg Roedel
2008-09-03 18:04 ` [PATCH 0/3] fix swiotlb allocation gfp flag FUJITA Tomonori
2008-09-03 18:04 ` [PATCH 1/3] x86: remove the NULL device hack in dma-mapping.h FUJITA Tomonori
2008-09-03 18:04 ` [PATCH 2/3] x86: set gfp flag properly for swiotlb_alloc_coherent FUJITA Tomonori
2008-09-03 18:04 ` [PATCH 3/3] swiotlb: use GFP_DMA32 instead of GFP_DMA in swiotlb_alloc_coherent FUJITA Tomonori
2008-09-03 20:05 ` Joerg Roedel
2008-09-04 4:11 ` FUJITA Tomonori
2008-09-03 18:54 ` [PATCH 1/3] x86: remove the NULL device hack in dma-mapping.h FUJITA Tomonori
2008-09-03 20:01 ` Joerg Roedel
2008-09-04 4:11 ` FUJITA Tomonori
2008-09-04 10:00 ` Joerg Roedel
2008-09-04 12:50 ` FUJITA Tomonori
2008-09-03 18:05 ` [PATCH] swiotlb: fix dma_alloc_coherent allocation failures with swiotlb FUJITA Tomonori
2008-09-03 19:54 ` Joerg Roedel
2008-09-03 20:11 ` Joerg Roedel
2008-09-04 4:11 ` FUJITA Tomonori
2008-09-03 22:09 ` Andi Kleen
2008-09-04 4:11 ` FUJITA Tomonori
2008-09-04 7:44 ` Andi Kleen [this message]
2008-09-04 7:58 ` FUJITA Tomonori
2008-09-04 8:05 ` Andi Kleen
2008-09-04 8:18 ` FUJITA Tomonori
2008-09-04 8:31 ` Andi Kleen
2008-09-04 9:49 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080904074441.GY18288@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=hpa@zytor.com \
--cc=iommu@lists.linux-foundation.org \
--cc=joerg.roedel@amd.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox