Re: [PATCH] x86: gart alloc_coherent doesn't need to check NULL device argument

Joerg Roedel
2008-09-05T10:42:01Z

True, thanks.

On Fri, Sep 05, 2008 at 05:58:49PM +0900, FUJITA Tomonori wrote:
> asm/dma-mapping.h guarantees that gart alloc_coherent doesn't get NULL
> device argument.
>
> Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>

Acked-by: Joerg Roedel <joerg.roedel@amd.com>

> ---
> arch/x86/kernel/pci-gart_64.c | 3 ---
> 1 files changed, 0 insertions(+), 3 deletions(-)
>
> diff --git a/arch/x86/kernel/pci-gart_64.c b/arch/x86/kernel/pci-gart_64.c
> index 4d08649..0b99d4a 100644
> --- a/arch/x86/kernel/pci-gart_64.c
> +++ b/arch/x86/kernel/pci-gart_64.c
> @@ -506,9 +506,6 @@ gart_alloc_coherent(struct device *dev, size_t size, dma_addr_t *dma_addr,
>
> align_mask = (1UL << get_order(size)) - 1;
>
> - if (!dev)
> - dev = &x86_dma_fallback_dev;
> -
> *dma_addr = dma_map_area(dev, __pa(vaddr), size, DMA_BIDIRECTIONAL,
> align_mask);
> flush_gart();
> --
> 1.5.4.2
>
>

--
| AMD Saxony Limited Liability Company & Co. KG
Operating | Wilschdorfer Landstr. 101, 01109 Dresden, Germany
System | Register Court Dresden: HRA 4896
Research | General Partner authorized to represent:
Center | AMD Saxony LLC (Wilmington, Delaware, US)
| General Manager of AMD Saxony LLC: Dr. Hans-R. Deppe, Thomas McCoy