From: Dean Nelson <dcn@sgi.com>
To: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>
Cc: Yinghai Lu <yhlu.kernel@gmail.com>, linux-kernel@vger.kernel.org
Subject: [PATCH] error missed ifndef CONFIG_HAVE_SPARSE_IRQ
Date: Fri, 5 Sep 2008 09:07:20 -0500 [thread overview]
Message-ID: <20080905140720.GA9393@sgi.com> (raw)
An error return from create_irq_nr() is 0, but an error return from
create_irq() is -1.
Signed-off-by: Dean Nelson <dcn@sgi.com>
---
drivers/pci/htirq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux/drivers/pci/htirq.c
===================================================================
--- linux.orig/drivers/pci/htirq.c 2008-09-05 08:04:21.000000000 -0500
+++ linux/drivers/pci/htirq.c 2008-09-05 08:07:45.000000000 -0500
@@ -144,7 +144,7 @@ int __ht_create_irq(struct pci_dev *dev,
#else
irq = create_irq();
#endif
- if (irq == 0) {
+ if (irq <= 0) {
kfree(cfg);
return -EBUSY;
}
next reply other threads:[~2008-09-05 14:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-05 14:07 Dean Nelson [this message]
2008-09-05 14:46 ` [PATCH] error missed ifndef CONFIG_HAVE_SPARSE_IRQ Ingo Molnar
2008-09-05 17:03 ` Yinghai Lu
2008-09-05 17:07 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080905140720.GA9393@sgi.com \
--to=dcn@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=yhlu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox