* [PATCH] error missed ifndef CONFIG_HAVE_SPARSE_IRQ
@ 2008-09-05 14:07 Dean Nelson
2008-09-05 14:46 ` Ingo Molnar
0 siblings, 1 reply; 4+ messages in thread
From: Dean Nelson @ 2008-09-05 14:07 UTC (permalink / raw)
To: Ingo Molnar, Thomas Gleixner; +Cc: Yinghai Lu, linux-kernel
An error return from create_irq_nr() is 0, but an error return from
create_irq() is -1.
Signed-off-by: Dean Nelson <dcn@sgi.com>
---
drivers/pci/htirq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux/drivers/pci/htirq.c
===================================================================
--- linux.orig/drivers/pci/htirq.c 2008-09-05 08:04:21.000000000 -0500
+++ linux/drivers/pci/htirq.c 2008-09-05 08:07:45.000000000 -0500
@@ -144,7 +144,7 @@ int __ht_create_irq(struct pci_dev *dev,
#else
irq = create_irq();
#endif
- if (irq == 0) {
+ if (irq <= 0) {
kfree(cfg);
return -EBUSY;
}
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] error missed ifndef CONFIG_HAVE_SPARSE_IRQ
2008-09-05 14:07 [PATCH] error missed ifndef CONFIG_HAVE_SPARSE_IRQ Dean Nelson
@ 2008-09-05 14:46 ` Ingo Molnar
2008-09-05 17:03 ` Yinghai Lu
0 siblings, 1 reply; 4+ messages in thread
From: Ingo Molnar @ 2008-09-05 14:46 UTC (permalink / raw)
To: Dean Nelson; +Cc: Thomas Gleixner, Yinghai Lu, linux-kernel
* Dean Nelson <dcn@sgi.com> wrote:
> An error return from create_irq_nr() is 0, but an error return from
> create_irq() is -1.
>
> Signed-off-by: Dean Nelson <dcn@sgi.com>
applied to tip/irq/sparseirq - thanks Dean!
Ingo
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] error missed ifndef CONFIG_HAVE_SPARSE_IRQ
2008-09-05 14:46 ` Ingo Molnar
@ 2008-09-05 17:03 ` Yinghai Lu
2008-09-05 17:07 ` Ingo Molnar
0 siblings, 1 reply; 4+ messages in thread
From: Yinghai Lu @ 2008-09-05 17:03 UTC (permalink / raw)
To: Ingo Molnar; +Cc: Dean Nelson, Thomas Gleixner, linux-kernel
On Fri, Sep 5, 2008 at 7:46 AM, Ingo Molnar <mingo@elte.hu> wrote:
>
> * Dean Nelson <dcn@sgi.com> wrote:
>
>> An error return from create_irq_nr() is 0, but an error return from
>> create_irq() is -1.
>>
>> Signed-off-by: Dean Nelson <dcn@sgi.com>
>
> applied to tip/irq/sparseirq - thanks Dean!
>
need to change irq to int too
diff --git a/drivers/pci/htirq.c b/drivers/pci/htirq.c
index 7c5aef1..468115d 100644
--- a/drivers/pci/htirq.c
+++ b/drivers/pci/htirq.c
@@ -109,7 +109,7 @@ int __ht_create_irq(struct pci_dev *dev, int idx,
ht_irq_update_t *update)
u32 data;
int max_irq;
int pos;
- unsigned int irq;
+ int irq;
unsigned int irq_want;
pos = pci_find_ht_capability(dev, HT_CAPTYPE_IRQ);
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] error missed ifndef CONFIG_HAVE_SPARSE_IRQ
2008-09-05 17:03 ` Yinghai Lu
@ 2008-09-05 17:07 ` Ingo Molnar
0 siblings, 0 replies; 4+ messages in thread
From: Ingo Molnar @ 2008-09-05 17:07 UTC (permalink / raw)
To: Yinghai Lu; +Cc: Dean Nelson, Thomas Gleixner, linux-kernel
* Yinghai Lu <yhlu.kernel@gmail.com> wrote:
> On Fri, Sep 5, 2008 at 7:46 AM, Ingo Molnar <mingo@elte.hu> wrote:
> >
> > * Dean Nelson <dcn@sgi.com> wrote:
> >
> >> An error return from create_irq_nr() is 0, but an error return from
> >> create_irq() is -1.
> >>
> >> Signed-off-by: Dean Nelson <dcn@sgi.com>
> >
> > applied to tip/irq/sparseirq - thanks Dean!
> >
> need to change irq to int too
applied to tip/irq/sparseirq - thanks.
Ingo
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-09-05 17:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-09-05 14:07 [PATCH] error missed ifndef CONFIG_HAVE_SPARSE_IRQ Dean Nelson
2008-09-05 14:46 ` Ingo Molnar
2008-09-05 17:03 ` Yinghai Lu
2008-09-05 17:07 ` Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox