From: Andrew Morton <akpm@linux-foundation.org>
To: Hiroshi DOYU <Hiroshi.DOYU@nokia.com>
Cc: linux-kernel@vger.kernel.org, tony@atomide.com
Subject: Re: [PATCH] Add missing macro argument for devm_release_* family
Date: Fri, 5 Sep 2008 18:52:54 -0700 [thread overview]
Message-ID: <20080905185254.78706060.akpm@linux-foundation.org> (raw)
In-Reply-To: <1220662823-19106-1-git-send-email-Hiroshi.DOYU@nokia.com>
On Sat, 6 Sep 2008 04:00:23 +0300 Hiroshi DOYU <Hiroshi.DOYU@nokia.com> wrote:
> From: ext Hiroshi DOYU <Hiroshi.DOYU@nokia.com>
>
> Signed-off-by: Hiroshi DOYU <Hiroshi.DOYU@nokia.com>
> ---
> include/linux/ioport.h | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/ioport.h b/include/linux/ioport.h
> index 22d2115..c813c63 100644
> --- a/include/linux/ioport.h
> +++ b/include/linux/ioport.h
> @@ -158,9 +158,9 @@ extern struct resource * __devm_request_region(struct device *dev,
> struct resource *parent, resource_size_t start,
> resource_size_t n, const char *name);
>
> -#define devm_release_region(start,n) \
> +#define devm_release_region(dev,start,n) \
> __devm_release_region(dev, &ioport_resource, (start), (n))
> -#define devm_release_mem_region(start,n) \
> +#define devm_release_mem_region(dev,start,n) \
> __devm_release_region(dev, &iomem_resource, (start), (n))
>
> extern void __devm_release_region(struct device *dev, struct resource *parent,
um, OK.
But none of these things appear to have any callers anywhere. Why
don't we just delete it all?
next prev parent reply other threads:[~2008-09-06 1:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-06 1:00 [PATCH] Add missing macro argument for devm_release_* family Hiroshi DOYU
2008-09-06 1:52 ` Andrew Morton [this message]
2008-09-06 5:18 ` Hiroshi DOYU
2008-09-06 5:23 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080905185254.78706060.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=Hiroshi.DOYU@nokia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox