public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: hpa@zytor.com, linux-kernel@vger.kernel.org, tglx@linutronix.de,
	yhlu.kernel@gmail.com, macro@linux-mips.org
Subject: Re: [patch 3/3] x86: io-apic - code style cleaning for setup_IO_APIC_irqs
Date: Fri, 5 Sep 2008 23:15:25 +0400	[thread overview]
Message-ID: <20080905191525.GC19334@lenovo> (raw)
In-Reply-To: <20080905183835.GA19215@elte.hu>

[Ingo Molnar - Fri, Sep 05, 2008 at 08:38:35PM +0200]
| 
| * Cyrill Gorcunov <gorcunov@gmail.com> wrote:
| 
| > So as you see it's more then enough self-solid :) So I wouldn't break 
| > it 'cause of printing. If we have enough memory for bit field - we 
| > could just mark there if pin is connected to irq and print connection 
| > map after. Don't get me wrong please - I just don't want to overload 
| > this function with additional call.
| 
| the compiler will inline that single-called function just fine, as long 
| as you declare it static.
| 
| spreading printouts over several functions isnt all that bad i think. We 
| could even drop the 'not connected' complication - it's evident enough 
| from the fact that nothing gets printed.
| 
| 	Ingo
|

Ingo, lets leave it as is for now :)

(we cshouldn't drop these messages since they show us what
exactly is wrong with MP table)
 
		- Cyrill -

  reply	other threads:[~2008-09-05 19:15 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20080904183748.950151853@gmail.com>
2008-09-04 18:37 ` [patch 1/3] x86: io-apic - use ARRAY_SIZE macro Cyrill Gorcunov
2008-09-05  8:02   ` Ingo Molnar
2008-09-04 18:37 ` [patch 2/3] x86: io-apic - declare irq_cfg_lock for SPARSE_IRQ only Cyrill Gorcunov
2008-09-05  8:03   ` Ingo Molnar
2008-09-04 18:37 ` [patch 3/3] x86: io-apic - code style cleaning for setup_IO_APIC_irqs Cyrill Gorcunov
2008-09-05  8:04   ` Ingo Molnar
2008-09-05 13:49     ` Cyrill Gorcunov
2008-09-05 18:01     ` Cyrill Gorcunov
2008-09-05 18:11       ` Ingo Molnar
2008-09-05 18:33         ` Cyrill Gorcunov
2008-09-05 18:38           ` Ingo Molnar
2008-09-05 19:15             ` Cyrill Gorcunov [this message]
2008-09-06 10:15             ` Cyrill Gorcunov
2008-09-06 13:12               ` Ingo Molnar
2008-09-08  0:24                 ` Yinghai Lu
2008-09-08  4:18                   ` Cyrill Gorcunov
2008-09-08  4:20                   ` Cyrill Gorcunov
2008-09-08  4:38                     ` Yinghai Lu
2008-09-08  5:07                       ` Yinghai Lu
2008-09-08  5:17                         ` Cyrill Gorcunov
2008-09-06 18:45               ` Maciej W. Rozycki
2008-09-06 18:49                 ` Ingo Molnar
2008-09-06 20:02                   ` Maciej W. Rozycki
2008-09-07 10:00                   ` Cyrill Gorcunov
2008-09-07 15:47                     ` Ingo Molnar
2008-09-07 16:04                       ` Cyrill Gorcunov
2008-09-06 19:04                 ` Cyrill Gorcunov
2008-09-06 19:16                   ` Yinghai Lu
2008-09-06 19:19                     ` Cyrill Gorcunov
2008-09-06 19:38                     ` Cyrill Gorcunov
2008-09-06 19:44                       ` Cyrill Gorcunov
2008-09-06 20:08                         ` Maciej W. Rozycki
2008-09-06 20:13                           ` Cyrill Gorcunov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080905191525.GC19334@lenovo \
    --to=gorcunov@gmail.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=macro@linux-mips.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    --cc=yhlu.kernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox