* [PATCH] Add missing macro argument for devm_release_* family
@ 2008-09-06 1:00 Hiroshi DOYU
2008-09-06 1:52 ` Andrew Morton
0 siblings, 1 reply; 4+ messages in thread
From: Hiroshi DOYU @ 2008-09-06 1:00 UTC (permalink / raw)
To: linux-kernel; +Cc: tony, ext Hiroshi DOYU
From: ext Hiroshi DOYU <Hiroshi.DOYU@nokia.com>
Signed-off-by: Hiroshi DOYU <Hiroshi.DOYU@nokia.com>
---
include/linux/ioport.h | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/ioport.h b/include/linux/ioport.h
index 22d2115..c813c63 100644
--- a/include/linux/ioport.h
+++ b/include/linux/ioport.h
@@ -158,9 +158,9 @@ extern struct resource * __devm_request_region(struct device *dev,
struct resource *parent, resource_size_t start,
resource_size_t n, const char *name);
-#define devm_release_region(start,n) \
+#define devm_release_region(dev,start,n) \
__devm_release_region(dev, &ioport_resource, (start), (n))
-#define devm_release_mem_region(start,n) \
+#define devm_release_mem_region(dev,start,n) \
__devm_release_region(dev, &iomem_resource, (start), (n))
extern void __devm_release_region(struct device *dev, struct resource *parent,
--
1.5.5.1.357.g1af8b
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] Add missing macro argument for devm_release_* family
2008-09-06 1:00 [PATCH] Add missing macro argument for devm_release_* family Hiroshi DOYU
@ 2008-09-06 1:52 ` Andrew Morton
2008-09-06 5:18 ` Hiroshi DOYU
0 siblings, 1 reply; 4+ messages in thread
From: Andrew Morton @ 2008-09-06 1:52 UTC (permalink / raw)
To: Hiroshi DOYU; +Cc: linux-kernel, tony
On Sat, 6 Sep 2008 04:00:23 +0300 Hiroshi DOYU <Hiroshi.DOYU@nokia.com> wrote:
> From: ext Hiroshi DOYU <Hiroshi.DOYU@nokia.com>
>
> Signed-off-by: Hiroshi DOYU <Hiroshi.DOYU@nokia.com>
> ---
> include/linux/ioport.h | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/ioport.h b/include/linux/ioport.h
> index 22d2115..c813c63 100644
> --- a/include/linux/ioport.h
> +++ b/include/linux/ioport.h
> @@ -158,9 +158,9 @@ extern struct resource * __devm_request_region(struct device *dev,
> struct resource *parent, resource_size_t start,
> resource_size_t n, const char *name);
>
> -#define devm_release_region(start,n) \
> +#define devm_release_region(dev,start,n) \
> __devm_release_region(dev, &ioport_resource, (start), (n))
> -#define devm_release_mem_region(start,n) \
> +#define devm_release_mem_region(dev,start,n) \
> __devm_release_region(dev, &iomem_resource, (start), (n))
>
> extern void __devm_release_region(struct device *dev, struct resource *parent,
um, OK.
But none of these things appear to have any callers anywhere. Why
don't we just delete it all?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Add missing macro argument for devm_release_* family
2008-09-06 1:52 ` Andrew Morton
@ 2008-09-06 5:18 ` Hiroshi DOYU
2008-09-06 5:23 ` Andrew Morton
0 siblings, 1 reply; 4+ messages in thread
From: Hiroshi DOYU @ 2008-09-06 5:18 UTC (permalink / raw)
To: akpm; +Cc: linux-kernel, tony
From: "ext Andrew Morton" <akpm@linux-foundation.org>
Subject: Re: [PATCH] Add missing macro argument for devm_release_* family
Date: Fri, 5 Sep 2008 18:52:54 -0700
> On Sat, 6 Sep 2008 04:00:23 +0300 Hiroshi DOYU <Hiroshi.DOYU@nokia.com> wrote:
>
> > From: ext Hiroshi DOYU <Hiroshi.DOYU@nokia.com>
> >
> > Signed-off-by: Hiroshi DOYU <Hiroshi.DOYU@nokia.com>
> > ---
> > include/linux/ioport.h | 4 ++--
> > 1 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/include/linux/ioport.h b/include/linux/ioport.h
> > index 22d2115..c813c63 100644
> > --- a/include/linux/ioport.h
> > +++ b/include/linux/ioport.h
> > @@ -158,9 +158,9 @@ extern struct resource * __devm_request_region(struct device *dev,
> > struct resource *parent, resource_size_t start,
> > resource_size_t n, const char *name);
> >
> > -#define devm_release_region(start,n) \
> > +#define devm_release_region(dev,start,n) \
> > __devm_release_region(dev, &ioport_resource, (start), (n))
> > -#define devm_release_mem_region(start,n) \
> > +#define devm_release_mem_region(dev,start,n) \
> > __devm_release_region(dev, &iomem_resource, (start), (n))
> >
> > extern void __devm_release_region(struct device *dev, struct resource *parent,
>
> um, OK.
>
> But none of these things appear to have any callers anywhere. Why
> don't we just delete it all?
Not sure for others, but at least, I am using this in my developing
driver;)
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Add missing macro argument for devm_release_* family
2008-09-06 5:18 ` Hiroshi DOYU
@ 2008-09-06 5:23 ` Andrew Morton
0 siblings, 0 replies; 4+ messages in thread
From: Andrew Morton @ 2008-09-06 5:23 UTC (permalink / raw)
To: Hiroshi DOYU; +Cc: linux-kernel, tony
On Sat, 06 Sep 2008 08:18:41 +0300 (EEST) Hiroshi DOYU <Hiroshi.DOYU@nokia.com> wrote:
> From: "ext Andrew Morton" <akpm@linux-foundation.org>
> Subject: Re: [PATCH] Add missing macro argument for devm_release_* family
> Date: Fri, 5 Sep 2008 18:52:54 -0700
>
> > On Sat, 6 Sep 2008 04:00:23 +0300 Hiroshi DOYU <Hiroshi.DOYU@nokia.com> wrote:
> >
> > > From: ext Hiroshi DOYU <Hiroshi.DOYU@nokia.com>
> > >
> > > Signed-off-by: Hiroshi DOYU <Hiroshi.DOYU@nokia.com>
> > > ---
> > > include/linux/ioport.h | 4 ++--
> > > 1 files changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/include/linux/ioport.h b/include/linux/ioport.h
> > > index 22d2115..c813c63 100644
> > > --- a/include/linux/ioport.h
> > > +++ b/include/linux/ioport.h
> > > @@ -158,9 +158,9 @@ extern struct resource * __devm_request_region(struct device *dev,
> > > struct resource *parent, resource_size_t start,
> > > resource_size_t n, const char *name);
> > >
> > > -#define devm_release_region(start,n) \
> > > +#define devm_release_region(dev,start,n) \
> > > __devm_release_region(dev, &ioport_resource, (start), (n))
> > > -#define devm_release_mem_region(start,n) \
> > > +#define devm_release_mem_region(dev,start,n) \
> > > __devm_release_region(dev, &iomem_resource, (start), (n))
> > >
> > > extern void __devm_release_region(struct device *dev, struct resource *parent,
> >
> > um, OK.
> >
> > But none of these things appear to have any callers anywhere. Why
> > don't we just delete it all?
>
> Not sure for others, but at least, I am using this in my developing
> driver;)
yeah, I was just trolling ;)
I queued this fix for 2.6.27.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-09-06 5:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-09-06 1:00 [PATCH] Add missing macro argument for devm_release_* family Hiroshi DOYU
2008-09-06 1:52 ` Andrew Morton
2008-09-06 5:18 ` Hiroshi DOYU
2008-09-06 5:23 ` Andrew Morton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox