From: Ingo Molnar <mingo@elte.hu>
To: Manfred Spraul <manfred@colorfullife.com>
Cc: linux-kernel@vger.kernel.org, paulmck@linux.vnet.ibm.com,
akpm@linux-foundation.org
Subject: Re: [PATCH] kernel/cpu.c: Move the CPU_DYING notifiers
Date: Sat, 6 Sep 2008 19:13:45 +0200 [thread overview]
Message-ID: <20080906171345.GH4856@elte.hu> (raw)
In-Reply-To: <48C2B90C.8000205@colorfullife.com>
* Manfred Spraul <manfred@colorfullife.com> wrote:
> Ingo Molnar wrote:
>> * Manfred Spraul <manfred@colorfullife.com> wrote:
>>
>>> - raw_notifier_call_chain(&cpu_chain, CPU_DYING | param->mod,
>>> - param->hcpu);
>>> /* Ensure this CPU doesn't handle any more interrupts. */
>>> err = __cpu_disable();
>>> if (err < 0)
>>> return err;
>>> + raw_notifier_call_chain(&cpu_chain, CPU_DYING | param->mod,
>>> + param->hcpu);
>>>
>>
>> hm, doesnt this break things like CPU cross-calls done in CPU_DYING
>> callbacks?
>>
>
> We are within stop_machine(). No other cpu is running. As fas as I can
> see no cross-calls are possible.
ah, ok - my bad. I was confusing it with the much more common
CPU_DOWN_PREPARE type of callbacks which do use various cross-CPU APIs.
applied to tip/sched/devel, thanks Manfred!
Ingo
next prev parent reply other threads:[~2008-09-06 17:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-31 17:58 [PATCH] kernel/cpu.c: Move the CPU_DYING notifiers Manfred Spraul
2008-08-31 19:17 ` Paul E. McKenney
2008-08-31 19:23 ` Paul E. McKenney
2008-09-06 16:49 ` Ingo Molnar
2008-09-06 17:08 ` Manfred Spraul
2008-09-06 17:13 ` Ingo Molnar [this message]
2008-09-13 6:36 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080906171345.GH4856@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manfred@colorfullife.com \
--cc=paulmck@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox