Re: [PATCH] genirq: irq_chip->startup() usage in setup_irq and set_irq_chained handler

Ingo Molnar
2008-08-23T16:09:28Z

* Pawel MOLL <pawel.moll@st.com> wrote:

> Hi, Ingo,
>
> Apparently I have swapped To: and Cc: field in the original mail,
> apologies.
>
> > This patch clarifies a usage of irq_chip->startup() callback:
> >
> > 1. The "if (startup) startup(); else enabled();" code in setup_irq()
> > is unnecessary, as startup() falls back to enabled() via
> > default callbacks, set by irq_chip_set_defaults().
> >
> > 2. When using set_irq_chained_handler() the startup() was never called,
> > which is not good at all... Fixed. And again - when startup() is not
> > defined the call will fall back to enable() than to unmask() via
> > default callbacks.
>
> Any comment on the patch?

looks good to me at first glance - but i Cc:-ed Thomas and Ben, maybe
they have further comments.

Ingo