Re: [patch 3/3] x86: io-apic - code style cleaning for setup_IO_APIC_irqs

Cyrill Gorcunov
2008-09-06T20:13:44Z

[Maciej W. Rozycki - Sat, Sep 06, 2008 at 09:08:51PM +0100]
| On Sat, 6 Sep 2008, Cyrill Gorcunov wrote:
|
| > So I think better would be just use Ingo's suggestion
| > about to separate apic/pin iterator and function body.
|
| No doubt about it. Then if the number of entries was to be huge, then
| lines output to the log buffer could be limited to 80 characters. With
| the use of sprintf() it would be rather trivial. And you would avoid any
| concerns about stack consumption.
|
| Please note that with MPS 1.1 systems the number of "unconnected" I/O
| APIC inputs can be considerable.
|
| Maciej
|

Thanks Maciej, will continue tomorrow.

- Cyrill -