Re: [PATCH] fix RTC_CLASS regression with PARISC

James Bottomley
2008-09-08T23:00:59Z

On Mon, 2008-09-08 at 14:35 -0700, David Miller wrote:
> From: David Brownell <david-b@pacbell.net>
> Date: Mon, 8 Sep 2008 14:29:57 -0700
>
> > On Monday 08 September 2008, James Bottomley wrote:
> > > All the PDC real time clock calls can do are read and set, nothing else,
> > > so it's idealy suited to the GEN_RTC infrastructure ... what's the
> > > benefit in moving it to RTC_CLASS?
> >
> > The same benefit always found in sharing infrastructure. Lots
> > of little differences/bugs go away. Infrastructure improvements
> > and bugfixes get leveraged. Dead and crufticious code can vanish.
> > And so forth.
>
> I absolutely and positively agree with David here.
>
> I just last week converted all of both sparc ports to the generic
> RTC layer and what a huge burdon has been moved off of my shoulders.
>
> The RTC layer is very nice and it even allows writing drivers for
> very simplistic RTC devices (even ones that cannot be written)
> with ease. I had two such cases to handle on sparc64.

I'm guessing they're not upstream yet (since I can't find them)?

However, if you based them on rtc-ppc.c then yes, I agree, it looks
reasonably easy: it's just a matter of converting over the GEN_RTC
PDT_TOD helpers.

On a related note ... I could do this specifically for parisc, but I
could also do a GEN_RTC conversion to PDC_CLASS ... would that be more
helpful?

James