Re: [PATCH] fix RTC_CLASS regression with PARISC

David Miller
2008-09-08T21:35:29Z

From: David Brownell <david-b@pacbell.net>
Date: Mon, 8 Sep 2008 14:29:57 -0700

> On Monday 08 September 2008, James Bottomley wrote:
> > All the PDC real time clock calls can do are read and set, nothing else,
> > so it's idealy suited to the GEN_RTC infrastructure ... what's the
> > benefit in moving it to RTC_CLASS?
>
> The same benefit always found in sharing infrastructure. Lots
> of little differences/bugs go away. Infrastructure improvements
> and bugfixes get leveraged. Dead and crufticious code can vanish.
> And so forth.

I absolutely and positively agree with David here.

I just last week converted all of both sparc ports to the generic
RTC layer and what a huge burdon has been moved off of my shoulders.

The RTC layer is very nice and it even allows writing drivers for
very simplistic RTC devices (even ones that cannot be written)
with ease. I had two such cases to handle on sparc64.