Re: [PATCH] fix RTC_CLASS regression with PARISC

James Bottomley
2008-09-08T18:40:05Z

On Mon, 2008-09-08 at 11:19 -0700, David Brownell wrote:
> On Monday 08 September 2008, James Bottomley wrote:
> > Put it back again by making RTC_CLASS
> > unselectable if the architecture is parisc.
>
> Easier if those distros just wouldn't select RTC_CLASS then. :)

Yes, but think of distro config people rather like users ... if you can
prevent them from doing something stupid, it's a good idea. In this
case, there's currently no way anyone should ever select RTC_CLASS on
parisc, so we should make that clear in the Kconfig file.

> And long term, better to work with RTC_CLASS. Eliminate that
> crufty asm-parisc/rtc.h file and one more GEN_RTC user; and
> share more widely-used infrastructure.
>
> If I read things right, that would be easy: the PARISC RTC is
> two firmware calls, ptc_tod_{read,set}(), which would map to
> RTC class {read,set}_time() methods of about six lines each.
> The RTC framework can do UIE emulation, if needed.

OK, I can look at that, but in the mean time could we make the option
that causes the damage unselectable? This is technically a regression
because before your patch GEN_RTC would override RTC_CLASS, now it's the
other way around.

James