Re: [PATCH] fix RTC_CLASS regression with PARISC

David Brownell
2008-09-09T03:24:19Z

On Monday 08 September 2008, David Miller wrote:
>
> > > int update_persistent_clock(struct timespec now)
> > > {
> > >     struct rtc_device *rtc = rtc_class_open("rtc0");

One more point: that should probably use CONFIG_RTC_HCTOSYS_DEVICE
instead of hard-wiring to "rtc0". Yeah, I'm sure your SPARCs have
lots of RTCs to choose from -- not! -- but I'd like to see you end
up with code that many folk can reuse/recycle/pirate. ;)

> >
> > I'd be tempted to cache that ... notice how you never
> > close it, too.  That will goof lots of refcounts...
>
> Well if I cache it then we'll hold it forever and that's not
> so nice right?

Why wouldn't it be, so long as it's eventually closed
to prevent leakage? Other code can rtc_class_open() too;
unlike a userspace open("/dev/rtc0", ...) this isn't an
exclusive operation.

> I'm going to put the missing rtc_close() in there for now to
> fix the leak.
>
> I'm happy to cache this if you think it's warranted, but then
> this is like saying that the refcount doesn't matter :-)

If you're concerned about stuff like "rmmod my-i2c-rtc-driver"
losing (or "rmmod my-i2c-rtc-driver's-i2c-adapter") ... what's
supposed to happen is that you start getting an -ENODEV return
from your rtc_set_mmss() call, and then you close and null your
cached handle to free up its memory.

The next time you go through this routine you'd see nothing
is cached and then try to get an RTC. Maybe it's available
again; maybe not.

- Dave