Re: [PATCH] fix RTC_CLASS regression with PARISC

Paul Mackerras
2008-09-09T01:24:05Z

David Miller writes:

> int update_persistent_clock(struct timespec now)
> {
> struct rtc_device *rtc = rtc_class_open("rtc0");
>
> if (rtc)
> return rtc_set_mmss(rtc, now.tv_sec);
>
> return -1;
> }
>
> and that should handle this NTP shouldn't it?

Yes as long as your rtc set functions don't need to sleep, since
update_persistent_clock is called at interrupt level. Some powerpc
systems have their RTC at the far end of an I2C bus, and the I2C
access routines can sleep.

Paul.