From: Ingo Molnar <mingo@elte.hu>
To: Vegard Nossum <vegard.nossum@gmail.com>
Cc: Pekka Enberg <penberg@cs.helsinki.fi>, linux-kernel@vger.kernel.org
Subject: Re: [GIT PULL] kmemcheck updates for tip/kmemcheck
Date: Mon, 8 Sep 2008 17:17:53 +0200 [thread overview]
Message-ID: <20080908151753.GE10580@elte.hu> (raw)
In-Reply-To: <20080907200943.GA2665@localhost.localdomain>
* Vegard Nossum <vegard.nossum@gmail.com> wrote:
> Ingo,
>
> Here follows a small update to the REP instruction handling and
> removal of some obsolete code (if you worry that this is useful code,
> git will save it for us and it can be revived if needed. I believe
> that the code is simply a burden as it is today).
pulled into tip/kmemcheck, thanks Vegard!
> I couldn't figure out how to merge v2.6.27-rc5 without littering the
> pull request with all the commits that were made in Linus's repository
> since v2.6.27-rc3, but feel free to do it yourself. There should be no
> conflicts.
yeah, merges should generally be done in the upstream repo. Obviously
git-request-pull must list all the commits that happened - it doesnt
know which commits are 'interesting' or not. I've done an upstream
merge.
btw., a small build fix (see below) was needed.
Ingo
---------------->
>From 92a9abb2c571ab8fedaee3537c5667b4e61188ce Mon Sep 17 00:00:00 2001
From: Ingo Molnar <mingo@elte.hu>
Date: Mon, 8 Sep 2008 16:50:43 +0200
Subject: [PATCH] kmemcheck: build fix
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
fix:
arch/x86/mm/kmemcheck/kmemcheck.c: In function ‘kmemcheck_init’:
arch/x86/mm/kmemcheck/kmemcheck.c:42: error: ‘setup_max_cpus’ undeclared (first use in this function)
arch/x86/mm/kmemcheck/kmemcheck.c:42: error: (Each undeclared identifier is reported only once
arch/x86/mm/kmemcheck/kmemcheck.c:42: error: for each function it appears in.)
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
arch/x86/mm/kmemcheck/kmemcheck.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/arch/x86/mm/kmemcheck/kmemcheck.c b/arch/x86/mm/kmemcheck/kmemcheck.c
index eef8c6a..75831f0 100644
--- a/arch/x86/mm/kmemcheck/kmemcheck.c
+++ b/arch/x86/mm/kmemcheck/kmemcheck.c
@@ -35,6 +35,7 @@ void __init kmemcheck_init(void)
{
printk(KERN_INFO "kmemcheck: \"Bugs, beware!\"\n");
+#if defined(CONFIG_SMP) && !defined(CONFIG_KMEMCHECK_USE_SMP)
/*
* Limit SMP to use a single CPU. We rely on the fact that this code
* runs before SMP is set up.
@@ -44,6 +45,7 @@ void __init kmemcheck_init(void)
"kmemcheck: Limiting number of CPUs to 1.\n");
setup_max_cpus = 1;
}
+#endif
}
#ifdef CONFIG_KMEMCHECK_DISABLED_BY_DEFAULT
next prev parent reply other threads:[~2008-09-08 15:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-07 20:09 [GIT PULL] kmemcheck updates for tip/kmemcheck Vegard Nossum
2008-09-08 15:17 ` Ingo Molnar [this message]
2008-09-08 15:24 ` Vegard Nossum
2008-09-08 15:26 ` Vegard Nossum
2008-09-08 17:08 ` Ingo Molnar
-- strict thread matches above, loose matches on Subject: below --
2008-08-29 21:19 Vegard Nossum
2008-09-06 17:16 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080908151753.GE10580@elte.hu \
--to=mingo@elte.hu \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
--cc=vegard.nossum@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox