Re: [RFC] bridge: STP timer management range checking

Stephen Hemminger
2008-08-31T23:29:37Z

Alan Cox wrote:
> On Sun, 31 Aug 2008 10:43:09 -0700
> Stephen Hemminger <shemminger@vyatta.com> wrote:
>
>
>> The Spanning Tree Protocol timers need to be set within certain boundaries
>> to keep the internal protocol engine working, and to be interoperable.
>> This patch restricts changes to those timers to the values defined in IEEE 802.1D
>> specification.
>>
>
> Why do we care ? You have to be the network administrator to set values,
> there are cases you may want to be out of the spec and you are
> privileged. The kernel does need to stop things being done which are
> fatal but running around restricting privileged administrators who have
> the ability to bring the network down anyway isn't its job.
>
> Seems bogus extra code to me - stops things working that should be
> allowed too.
>
The timer configuration is propagated in network protocol, so
misconfigured Linux box
could survive but effect other devices on the network that are less
robust. Maybe the
small values would cause some other bridge to crash, go infinite loop, ...
More likely robust devices might ignore our packets (because values out
of range), leading to
routing loops and other disasters.

The kernel does need to stop administrative settings from taking out a
network. If someone
has a custom device or other non-standard usage, they can always rebuild
the kernel and
remove the range check.