From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: LKML <linux-kernel@vger.kernel.org>,
Yinghai Lu <yhlu.kernel@gmail.com>,
"Maciej W. Rozycki" <macro@linux-mips.org>
Subject: [PATCH] x86: io-apic - do not use KERN_DEBUG marker too much
Date: Mon, 8 Sep 2008 19:38:06 +0400 [thread overview]
Message-ID: <20080908153806.GB7278@lenovo> (raw)
Do not use KERN_DEBUG several times on the same line being printed.
Introduced by mine previous patch, sorry.
Reported-by: Yinghai Lu <yhlu.kernel@gmail.com>
Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
---
Index: linux-2.6.git/arch/x86/kernel/io_apic.c
===================================================================
--- linux-2.6.git.orig/arch/x86/kernel/io_apic.c 2008-09-08 19:32:34.000000000 +0400
+++ linux-2.6.git/arch/x86/kernel/io_apic.c 2008-09-08 19:34:10.000000000 +0400
@@ -1526,11 +1526,16 @@ static void __init setup_IO_APIC_irqs(vo
idx = find_irq_entry(apic, pin, mp_INT);
if (idx == -1) {
- apic_printk(APIC_VERBOSE,
- KERN_DEBUG " %d-%d",
- mp_ioapics[apic].mp_apicid, pin);
- if (!notcon)
+ if (!notcon) {
notcon = 1;
+ apic_printk(APIC_VERBOSE,
+ KERN_DEBUG " %d-%d",
+ mp_ioapics[apic].mp_apicid,
+ pin);
+ } else
+ apic_printk(APIC_VERBOSE, " %d-%d",
+ mp_ioapics[apic].mp_apicid,
+ pin);
continue;
}
@@ -1546,14 +1551,14 @@ static void __init setup_IO_APIC_irqs(vo
}
if (notcon) {
apic_printk(APIC_VERBOSE,
- KERN_DEBUG " (apicid-pin) not connected\n");
+ " (apicid-pin) not connected\n");
notcon = 0;
}
}
if (notcon)
apic_printk(APIC_VERBOSE,
- KERN_DEBUG " (apicid-pin) not connected\n");
+ " (apicid-pin) not connected\n");
}
/*
next reply other threads:[~2008-09-08 15:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-08 15:38 Cyrill Gorcunov [this message]
2008-09-12 19:55 ` [PATCH] x86: io-apic - do not use KERN_DEBUG marker too much Yinghai Lu
2008-09-12 19:57 ` Yinghai Lu
2008-09-12 20:18 ` Cyrill Gorcunov
2008-09-13 0:40 ` Maciej W. Rozycki
2008-09-13 9:11 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080908153806.GB7278@lenovo \
--to=gorcunov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=macro@linux-mips.org \
--cc=mingo@elte.hu \
--cc=yhlu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox