public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Cc: mingo@redhat.com, joerg.roedel@amd.com,
	linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org
Subject: Re: [PATCH 0/3] fix alloc_coherent allocation issues (tip/x86/iommu)
Date: Mon, 8 Sep 2008 20:15:29 +0200	[thread overview]
Message-ID: <20080908181529.GA8536@elte.hu> (raw)
In-Reply-To: <20080909030508F.fujita.tomonori@lab.ntt.co.jp>


* FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp> wrote:

> Very sorry, I should have compile this on X86_32...
> 
> Can you replace the fourth patch with this?

some other commits came inbetween already - i applied the delta below.

	Ingo

--------------->
>From 53f79ced9d2c42a52290b460b88a4720a481a3ed Mon Sep 17 00:00:00 2001
From: Ingo Molnar <mingo@elte.hu>
Date: Mon, 8 Sep 2008 20:13:06 +0200
Subject: [PATCH] x86: fix alloc_coherent allocation issues (tip/x86/iommu), warning fixes

fix warnings.

Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 include/asm-x86/dma-mapping.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/include/asm-x86/dma-mapping.h b/include/asm-x86/dma-mapping.h
index 0cc022b..5607532 100644
--- a/include/asm-x86/dma-mapping.h
+++ b/include/asm-x86/dma-mapping.h
@@ -253,9 +253,9 @@ static inline unsigned long dma_alloc_coherent_mask(struct device *dev,
 
 static inline gfp_t dma_alloc_coherent_gfp_flags(struct device *dev, gfp_t gfp)
 {
+#ifdef CONFIG_X86_64
 	unsigned long dma_mask = dma_alloc_coherent_mask(dev, gfp);
 
-#ifdef CONFIG_X86_64
 	if (dma_mask <= DMA_32BIT_MASK && !(gfp & GFP_DMA))
 		gfp |= GFP_DMA32;
 #endif

      reply	other threads:[~2008-09-08 18:16 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-05  8:58 [PATCH 0/3] fix alloc_coherent allocation issues (tip/x86/iommu) FUJITA Tomonori
2008-09-05  8:58 ` [PATCH] x86: fix nommu_alloc_coherent allocation with NULL device argument FUJITA Tomonori
2008-09-05  8:58   ` [PATCH] x86: use __GFP_NORETRY in the case of GFP_DMA with pci-nommu FUJITA Tomonori
2008-09-05  8:58     ` [PATCH] x86: gart alloc_coherent doesn't need to check NULL device argument FUJITA Tomonori
2008-09-05 10:41       ` Joerg Roedel
2008-09-05 10:43     ` [PATCH] x86: use __GFP_NORETRY in the case of GFP_DMA with pci-nommu Joerg Roedel
2008-09-06 12:18       ` FUJITA Tomonori
2008-09-08 11:41         ` Joerg Roedel
2008-09-05 10:40   ` [PATCH] x86: fix nommu_alloc_coherent allocation with NULL device argument Joerg Roedel
2008-09-05 10:49     ` Ingo Molnar
2008-09-05 11:56     ` Joerg Roedel
2008-09-06 12:18     ` FUJITA Tomonori
2008-09-05  9:11 ` [PATCH 0/3] fix alloc_coherent allocation issues (tip/x86/iommu) FUJITA Tomonori
2008-09-05 10:45   ` Ingo Molnar
2008-09-08 17:35     ` Ingo Molnar
2008-09-08 18:06       ` FUJITA Tomonori
2008-09-08 18:15         ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080908181529.GA8536@elte.hu \
    --to=mingo@elte.hu \
    --cc=fujita.tomonori@lab.ntt.co.jp \
    --cc=iommu@lists.linux-foundation.org \
    --cc=joerg.roedel@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox