Re: [PATCH v2 01/13] PCI Hotplug core: add 'name' param pci_hp_register interface

Matthew Wilcox
2008-09-09T12:05:46Z

On Tue, Sep 09, 2008 at 04:00:07AM -0600, Alex Chiang wrote:
> -extern int pci_hp_register(struct hotplug_slot *, struct pci_bus *, int nr);
> +extern int pci_hp_register(struct hotplug_slot *,
> + struct pci_bus *,
> + int nr,
> + const char *name);

Not a huge fan of this style ... the usual style would be:

extern int pci_hp_register(struct hotplug_slot *, struct pci_bus *, int nr,
const char *name);

Otherwise Acked-by: Matthew Wilcox <willy@linux.intel.com>

--
Matthew Wilcox Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."