From: "Serge E. Hallyn" <serue@us.ibm.com>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Cedric Le Goater <clg@fr.ibm.com>,
Andrew Morton <akpm@linux-foundation.org>,
Trond Myklebust <trond.myklebust@fys.uio.no>,
Chuck Lever <chuck.lever@oracle.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Containers <containers@lists.osdl.org>,
linux-nfs@vger.kernel.org
Subject: Re: [RFC][PATCH] sunrpc: fix oops in rpc_create() when the mount namespace is unshared
Date: Tue, 9 Sep 2008 10:29:52 -0500 [thread overview]
Message-ID: <20080909152952.GA21207@us.ibm.com> (raw)
In-Reply-To: <m18wu1nyon.fsf@frodo.ebiederm.org>
Quoting Eric W. Biederman (ebiederm@xmission.com):
> "Serge E. Hallyn" <serue@us.ibm.com> writes:
>
> > Thanks, Cedric. Eric is probably right about the long-term fix, but
> > yeah it might take a while to properly wade through the sunrpc and nfs
> > layers to store the nodename at nfs mount time, and in the meantime this
> > fixes a real oops.
>
> A very esoteric oops that hasn't shown up for two years.
But an easily reproducible one.
It's not as though we'll stop looking for the right fix just bc we have
this "bad" fix in for a short while.
> Please let's look at this and see what it would take to fix this
> properly.
Of course. Cedric is looking at the best way to fix it...
> What are we trying to achieve by reading utsname?
It looks like it gets copied into the sunrpc messages so I assume it is
a part of the sunrpc spec?
I don't want to do this, but we *could* put a conditional in utsname()
to have it return init_utsname if current->nsproxy is null...
-serge
next prev parent reply other threads:[~2008-09-09 15:30 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-08 13:39 [RFC][PATCH] sunrpc: fix oops in rpc_create() when the mount namespace is unshared Cedric Le Goater
2008-09-08 15:19 ` Serge E. Hallyn
2008-09-08 15:27 ` Serge E. Hallyn
2008-09-08 15:37 ` Cedric Le Goater
2008-09-08 15:43 ` Serge E. Hallyn
2008-09-08 16:09 ` Eric W. Biederman
2008-09-09 11:54 ` Cedric Le Goater
2008-09-09 12:43 ` Serge E. Hallyn
2008-09-09 15:09 ` Eric W. Biederman
2008-09-09 15:29 ` Serge E. Hallyn [this message]
2008-09-09 15:40 ` Cedric Le Goater
2008-09-09 17:07 ` Chuck Lever
2008-09-09 18:20 ` Eric W. Biederman
2008-09-09 19:00 ` Chuck Lever
2008-09-09 20:08 ` Eric W. Biederman
2008-09-10 9:23 ` Cedric Le Goater
2008-09-10 15:12 ` Chuck Lever
2008-09-10 20:02 ` Eric W. Biederman
2008-09-10 20:54 ` Chuck Lever
2008-09-11 9:02 ` Cedric Le Goater
2008-09-11 10:27 ` Eric W. Biederman
2008-09-11 16:39 ` Chuck Lever
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080909152952.GA21207@us.ibm.com \
--to=serue@us.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=chuck.lever@oracle.com \
--cc=clg@fr.ibm.com \
--cc=containers@lists.osdl.org \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox