From: Ingo Molnar <mingo@elte.hu>
To: Alex Nixon <alex.nixon@citrix.com>
Cc: Jeremy Fitzhardinge <jeremy@goop.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 2/2] xen: fix pinning when not using split pte locks
Date: Wed, 10 Sep 2008 10:10:27 +0200 [thread overview]
Message-ID: <20080910081027.GD15255@elte.hu> (raw)
In-Reply-To: <48C70526.1030701@citrix.com>
* Alex Nixon <alex.nixon@citrix.com> wrote:
> Jeremy Fitzhardinge wrote:
>> We only pin PTE pages when using split PTE locks, so don't do the
>> pin/unpin when attaching/detaching pte pages to a pinned pagetable.
>>
>> Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
>> ---
>>
> Cheers Jeremy - a better solution. Worth mentioning - this doesn't
> exist peacefully alongside my patch 965fe78fe
>
> Ingo - could you revert that please?
yes - that looked odd and un-ack-ed anyway - but i applied it [it's at
the tail of x86/xen and easy to zap] because it solved a BUG_ON().
Btw., i suggested a different workflow to you in the past: please run
Xen patches by Jeremy and ask him for Acks and Cc: him - thanks.
Ingo
prev parent reply other threads:[~2008-09-10 8:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-09 11:25 [PATCH] Xen: Fix pte unpin BUG when !CONFIG_SMP Alex Nixon
2008-09-09 11:27 ` Ingo Molnar
2008-09-09 18:05 ` Jeremy Fitzhardinge
2008-09-09 19:21 ` Alex Nixon
2008-09-09 20:37 ` Jeremy Fitzhardinge
2008-09-09 22:26 ` Alex Nixon
2008-09-09 22:28 ` Jeremy Fitzhardinge
2008-09-09 22:43 ` [PATCH 1/2] mm: define USE_SPLIT_PTLOCKS rather than repeating expression Jeremy Fitzhardinge
2008-09-10 11:28 ` Hugh Dickins
2008-09-09 22:43 ` [PATCH 2/2] xen: fix pinning when not using split pte locks Jeremy Fitzhardinge
2008-09-09 22:53 ` Andrew Morton
2008-09-09 23:29 ` Jeremy Fitzhardinge
2008-09-10 8:18 ` Ingo Molnar
2008-09-09 23:22 ` Alex Nixon
2008-09-09 23:32 ` Jeremy Fitzhardinge
2008-09-10 8:10 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080910081027.GD15255@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=alex.nixon@citrix.com \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox