From: Ingo Molnar <mingo@elte.hu>
To: Joerg Roedel <joerg.roedel@amd.com>
Cc: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86: avoid unnecessary low zone allocation in AMD IOMMU's alloc_coherent
Date: Wed, 10 Sep 2008 14:18:35 +0200 [thread overview]
Message-ID: <20080910121835.GA14757@elte.hu> (raw)
In-Reply-To: <20080910120310.GD6329@amd.com>
* Joerg Roedel <joerg.roedel@amd.com> wrote:
> > + get_device_resources(dev, &iommu, &domain, &devid);
> > +
> > + if (iommu && domain)
> > + flag &= ~(__GFP_DMA | __GFP_HIGHMEM | __GFP_DMA32);
> > +
>
> These flags are already removed in the dma_alloc_coherent function
> which calls this one. Further I think in the case of a remapping IOMMU
> like this one we should avoid implementing any gfp hacks and just
> trust the caller.
or add a WARN_ON_ONCE() instead, to document and enforce that
assumption.
Ingo
next prev parent reply other threads:[~2008-09-10 12:19 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-10 11:19 [PATCH] x86: avoid unnecessary low zone allocation in AMD IOMMU's alloc_coherent FUJITA Tomonori
2008-09-10 11:57 ` Ingo Molnar
2008-09-10 12:03 ` Joerg Roedel
2008-09-10 12:18 ` Ingo Molnar [this message]
2008-09-10 12:38 ` FUJITA Tomonori
2008-09-10 12:48 ` Joerg Roedel
2008-09-10 13:03 ` FUJITA Tomonori
2008-09-10 13:10 ` Joerg Roedel
2008-09-10 13:37 ` FUJITA Tomonori
2008-09-10 13:53 ` Joerg Roedel
2008-09-10 14:24 ` FUJITA Tomonori
2008-09-10 14:38 ` Joerg Roedel
2008-09-10 14:45 ` FUJITA Tomonori
2008-09-11 9:10 ` Joerg Roedel
2008-09-11 13:36 ` FUJITA Tomonori
2008-09-10 14:39 ` FUJITA Tomonori
2008-09-10 14:52 ` Joerg Roedel
2008-09-10 15:09 ` FUJITA Tomonori
2008-09-10 15:29 ` Joerg Roedel
2008-09-10 16:29 ` FUJITA Tomonori
2008-09-10 17:05 ` Joerg Roedel
2008-09-10 17:15 ` FUJITA Tomonori
2008-09-10 17:25 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080910121835.GA14757@elte.hu \
--to=mingo@elte.hu \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=joerg.roedel@amd.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox