From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Christine Caulfield <caulfie@redhat.com>,
David Teigland <teigland@redhat.com>,
David Woodhouse <dwmw2@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] include <linux/types.h> into linux/dlm_plock.h for __u* typedef
Date: Wed, 10 Sep 2008 15:55:04 +0300 [thread overview]
Message-ID: <20080910125503.GG3757@localhost.localdomain> (raw)
In-Reply-To: <20080910121450.GA3468@x200.localdomain>
[-- Attachment #1: Type: text/plain, Size: 548 bytes --]
On Wed, Sep 10, 2008 at 04:14:50PM +0400, Alexey Dobriyan wrote:
> On Wed, Sep 10, 2008 at 02:22:04PM +0300, Kirill A. Shutemov wrote:
> > --- a/include/linux/dlm_plock.h
> > +++ b/include/linux/dlm_plock.h
>
> > +#include <linux/types.h>
>
> I'd say that unless you can demonstrate compilation breakage, these will
> only slow down compilation.
Do you think that minor slow down is worse than dependence on the order of
inclusion?
--
Regards, Kirill A. Shutemov
+ Belarus, Minsk
+ ALT Linux Team, http://www.altlinux.com/
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2008-09-10 12:54 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-10 11:22 [PATCH] include <linux/fs.h> into linux/ext2_fs.h Kirill A. Shutemov
2008-09-10 11:22 ` [PATCH] include <linux/types.h> into linux/dlm_plock.h for __u* typedef Kirill A. Shutemov
2008-09-10 11:22 ` [PATCH] include <linux/types.h> into linux/if_addrlabel.h " Kirill A. Shutemov
2008-09-10 11:22 ` [PATCH] include <linux/videodev2.h> into linux/ivtv.h Kirill A. Shutemov
2008-09-10 12:14 ` [PATCH] include <linux/types.h> into linux/dlm_plock.h for __u* typedef Alexey Dobriyan
2008-09-10 12:55 ` Kirill A. Shutemov [this message]
2008-09-10 13:11 ` Alexey Dobriyan
2008-09-10 13:15 ` Kirill A. Shutemov
2008-09-10 20:18 ` David Miller
2008-09-11 15:29 ` Kirill A. Shutemov
2008-09-10 14:20 ` David Woodhouse
2008-09-10 11:27 ` [PATCH] include <linux/fs.h> into linux/ext2_fs.h Christoph Hellwig
2008-09-10 11:40 ` Kirill A. Shutemov
2008-09-10 11:40 ` Christoph Hellwig
2008-09-10 11:49 ` Kirill A. Shutemov
2008-09-10 13:39 ` Eric Sandeen
2008-09-10 13:47 ` Kirill A. Shutemov
2008-09-10 14:57 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080910125503.GG3757@localhost.localdomain \
--to=kirill@shutemov.name \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=caulfie@redhat.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=teigland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox