public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Paul Jackson <pj@sgi.com>
To: Lai Jiangshan <laijs@cn.fujitsu.com>
Cc: akpm@linux-foundation.org, menage@google.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH -mm] cgroup,cpuset: use alternative malloc to allocate large memory buf for tasks
Date: Thu, 11 Sep 2008 05:56:30 -0500	[thread overview]
Message-ID: <20080911055630.b50e8717.pj@sgi.com> (raw)
In-Reply-To: <48C8F32E.2020004@cn.fujitsu.com>

Lai Jiangshan wrote:
> This new alternative allocation implementation can allocate memory
> up to 64M in 32bits system or 512M in 64bits system.

Just a random idea - it seems to me that this new allocation
implementation might be more generally useful than just for cgroups.

So, instead of having cgroup_huge_mem_alloc() and cgroup_huge_mem_free()
in kernel/cgroup.c, one might have say big_kmalloc() and big_kfree() in
some mm/*.c file.  I used "big" instead of "huge" or "compound" or
"large", as these other adjectives already have other meanings in these
allocator functions.

However ... I would suggest that you do not spend anytime implementing
the above idea unless either (1) it strikes you as absolutely brilliant,
or (2) Paul Menage endorses it.  Paul M has been paying closer attention
to this change than I have, so his recommendations are worth far more
than mine are here.

-- 
                  I won't rest till it's the best ...
                  Programmer, Linux Scalability
                  Paul Jackson <pj@sgi.com> 1.940.382.4214

  reply	other threads:[~2008-09-11 10:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-11 10:30 [PATCH -mm] cgroup,cpuset: use alternative malloc to allocate large memory buf for tasks Lai Jiangshan
2008-09-11 10:56 ` Paul Jackson [this message]
2008-09-11 16:45 ` Paul Menage
2008-09-11 19:54   ` Paul Menage

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080911055630.b50e8717.pj@sgi.com \
    --to=pj@sgi.com \
    --cc=akpm@linux-foundation.org \
    --cc=laijs@cn.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=menage@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox