Re: [RFC 4/4] switch non-standard SYSCALL_VECTOR allocation to use vector_irq[]

Ingo Molnar
2008-09-14T15:42:59Z

* Dean Nelson <dcn@sgi.com> wrote:

> + ret = __grab_irq_vector(NON_IRQ_DESC, syscall_vector,
> + &cpu_possible_map);
> + spin_unlock_irqrestore(&vector_lock, flags);
> + if (ret == false) {
> + printk("lg: couldn't reserve syscall %u\n",
> + syscall_vector);
> + return -EBUSY;
> + }

please use __grab_irq_vector() to standard return type: -EINVAL (or
-EBUSY) on failure, vector on success. That will get rid of the 'ret ==
false' ugliness too.

Ingo