public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: linux-kernel@vger.kernel.org,
	Thomas Gleixner <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH 6 of 7] x86: use early_ioremap in __acpi_map_table
Date: Thu, 11 Sep 2008 20:56:47 +0200	[thread overview]
Message-ID: <20080911185647.GA20188@elte.hu> (raw)
In-Reply-To: <48C9653F.1090805@goop.org>


* Jeremy Fitzhardinge <jeremy@goop.org> wrote:

> Ingo Molnar wrote:
> > the false positive should be avoided, for example by unmapping the 
> > 'prev' mapping shortly before the leak check.
> >   
> 
> Yep.  I'll make it unmap just before setting acpi_gbl_permanent_mmap,
> which is when it switches to using plain old ioremap.
> 
> >> (All those other backtraces are just informational, right?)
> >>     
> >
> > no, they cause hard failures in my test setup. Nor do we want to litter 
> > the bootup log with messages that are not correct.
> >   
> 
> No, I mean that early_ioremap_debug causes all early_ioremap()s to 
> dump a stack trace, so most of the stack dumps in the boot log are 
> diagnostic/informational rather than indications of lots of problems.

ah - now i understand what you mean, sure. The only non-diagnostic 
message that the test barfed on was the leak warning itself. The others 
were there because i did a second boot with the diagnostic messages 
enabled as well. (so that there's a full track of what is mapped where)

	Ingo

  reply	other threads:[~2008-09-11 18:57 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-07 22:21 [PATCH 0 of 7] x86: lay groundwork for Xen domain 0 support Jeremy Fitzhardinge
2008-09-07 22:21 ` [PATCH 1 of 7] x86: add _PAGE_IOMAP pte flag for IO mappings Jeremy Fitzhardinge
2008-09-09 13:32   ` Avi Kivity
2008-09-09 14:47     ` Jeremy Fitzhardinge
2008-09-09 14:56       ` Avi Kivity
2008-09-09 15:29         ` [Xen-devel] " Keir Fraser
2008-09-09 15:48           ` Jeremy Fitzhardinge
2008-09-09 16:05             ` Keir Fraser
2008-09-10  9:55         ` Avi Kivity
2008-09-10 16:38           ` Jeremy Fitzhardinge
2008-09-10 16:55             ` Nick Piggin
2008-09-10 17:27               ` Jeremy Fitzhardinge
2008-09-07 22:21 ` [PATCH 2 of 7] x86: remove duplicate early_ioremap declarations Jeremy Fitzhardinge
2008-09-07 22:21 ` [PATCH 3 of 7] x86: add early_memremap() Jeremy Fitzhardinge
2008-09-07 22:21 ` [PATCH 4 of 7] x86: use early_memremap() in setup.c Jeremy Fitzhardinge
2008-09-07 22:21 ` [PATCH 5 of 7] x86-64: don't check for map replacement Jeremy Fitzhardinge
2008-09-07 22:21 ` [PATCH 6 of 7] x86: use early_ioremap in __acpi_map_table Jeremy Fitzhardinge
2008-09-07 23:44   ` Andi Kleen
2008-09-08  0:03     ` Jeremy Fitzhardinge
2008-09-08 14:26       ` Ingo Molnar
2008-09-08 16:29         ` Jeremy Fitzhardinge
2008-09-08 19:41         ` Jeremy Fitzhardinge
2008-09-10 11:55         ` Ingo Molnar
2008-09-10 16:49           ` Jeremy Fitzhardinge
2008-09-11  7:33             ` Ingo Molnar
2008-09-11 18:36               ` Jeremy Fitzhardinge
2008-09-11 18:56                 ` Ingo Molnar [this message]
2008-09-11 20:34             ` Yinghai Lu
2008-09-11 21:07               ` Jeremy Fitzhardinge
2008-09-12  9:49                 ` Ingo Molnar
2008-09-12 17:31                   ` Yinghai Lu
     [not found]             ` <20080911125748.GA14698@elte.hu>
2008-09-11 21:33               ` [PATCH] acpi: remove final __acpi_map_table mapping before setting acpi_gbl_permanent_mmap Jeremy Fitzhardinge
2008-09-07 22:21 ` [PATCH 7 of 7] x86: always explicitly map acpi memory Jeremy Fitzhardinge
2008-09-07 23:35   ` [Xen-devel] " Yinghai Lu
2008-09-08  0:02     ` Jeremy Fitzhardinge
2008-09-08  0:14       ` Yinghai Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080911185647.GA20188@elte.hu \
    --to=mingo@elte.hu \
    --cc=hpa@zytor.com \
    --cc=jeremy@goop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox