From: Robin Holt <holt@sgi.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, Jack Steiner <steiner@sgi.com>,
Dean Nelson <dcn@sgi.com>
Subject: [Patch] Panic on ia64 when you modprobe -r xpc.
Date: Thu, 11 Sep 2008 15:40:50 -0500 [thread overview]
Message-ID: <20080911204050.GE8520@sgi.com> (raw)
If you are on ia64 and you modprobe xpc then modprobe -r xpc, you
immediately get a panic. xpc depends on xp which depends on gru for
a symbol. That symbol is only used when we are running on UV hardware.
Currently, the GRU driver detects we are not on UV hardware and does
no initializing. It does not do the same check when unloading. As a
result, the gru driver attempts to tear down stuff that was not setup.
This is a simple two-line workaround to get us through this release.
Once 2.6.28 is opened, we need to rework the symbols that xp is depending
on from gru so the gru driver can properly fail to load when hardware
is not available.
Signed-off-by: Robin Holt <holt@sgi.com>
Index: xpmem_v006_20080911/drivers/misc/sgi-gru/grufile.c
===================================================================
--- xpmem_v006_20080911.orig/drivers/misc/sgi-gru/grufile.c 2008-09-11 15:23:40.000000000 -0500
+++ xpmem_v006_20080911/drivers/misc/sgi-gru/grufile.c 2008-09-11 15:33:21.009814869 -0500
@@ -445,6 +445,9 @@ static void __exit gru_exit(void)
int order = get_order(sizeof(struct gru_state) *
GRU_CHIPLETS_PER_BLADE);
+ if (!IS_UV())
+ return;
+
for (i = 0; i < GRU_CHIPLETS_PER_BLADE; i++)
free_irq(IRQ_GRU + i, NULL);
reply other threads:[~2008-09-11 20:41 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080911204050.GE8520@sgi.com \
--to=holt@sgi.com \
--cc=dcn@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=steiner@sgi.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox