* PCI: Add ALI M5229 comaptibility mode quirk
@ 2008-09-12 11:22 Ben Dooks
2008-09-12 12:33 ` Matthew Wilcox
2008-09-13 14:24 ` Jeff Garzik
0 siblings, 2 replies; 8+ messages in thread
From: Ben Dooks @ 2008-09-12 11:22 UTC (permalink / raw)
To: linux-kernel, linux-pci; +Cc: Ben Dooks
[-- Attachment #1: simtec/simtec-add-ali-ide-pci-quirk.patch --]
[-- Type: text/plain, Size: 2238 bytes --]
The libata driver will not work with an M5229 set into native IDE
mode (the old drivers/pci one does) if the M5229 does not provide
it's own IRQ.
The M5229 implementation embedded into the ALI M1543 uses the
M1543's ISA PIC to provide the interrupts and thus does not have
an valid PCI IRQ set. This quirk detects the abscence of IRQ and
sets the M5229 back into compatibility mode to use IRQs 14 and 15
so that libata works correctly.
Note, I belive that the check for an valid interrupt line is
correct, I only have an M5229 in an ALI M1543 to check this
on. It would be useful to confirm that a M5229 with an valid IRQ
does not trigger this quirk.
Signed-off-by: Ben Dooks <ben-linux@fluff.org>
Index: linux-2.6.27-rc6-cats1/drivers/pci/quirks.c
===================================================================
--- linux-2.6.27-rc6-cats1.orig/drivers/pci/quirks.c 2008-09-11 11:26:35.000000000 +0100
+++ linux-2.6.27-rc6-cats1/drivers/pci/quirks.c 2008-09-12 12:18:05.000000000 +0100
@@ -905,6 +905,34 @@ static void __devinit quirk_svwks_csb5id
}
DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_SERVERWORKS, PCI_DEVICE_ID_SERVERWORKS_CSB5IDE, quirk_svwks_csb5ide);
+/* Some systems set the ALI M5229 in the ALI M1543 bridge to native mode,
+ * which cannot be supported by the pata_ali.c driver (the old drivers/ide
+ * makes a compatibility effort to change the IDE interrupts).
+ */
+static void __devinit quirk_ali_ide_compatibility(struct pci_dev *pdev)
+{
+ u8 tmp;
+
+ /* pdev->irq and pdev->pin have yet to be initialised, so check
+ * by reading from the configuration header to see if we've got
+ * a valid interrupt line. */
+
+ pci_read_config_byte(pdev, PCI_INTERRUPT_LINE, &tmp);
+ if (tmp != 0xff)
+ return;
+
+ pci_read_config_byte(pdev, PCI_CLASS_PROG, &tmp);
+ if (tmp & 0x5) {
+ dev_info(&pdev->dev, "quirk: changing to IDE compatibility mode\n");
+
+ tmp &= ~0x05;
+ pdev->class &= ~0x05;
+ pci_write_config_byte(pdev, PCI_CLASS_PROG, tmp);
+ }
+}
+
+DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_AL, PCI_DEVICE_ID_AL_M5229, quirk_ali_ide_compatibility);
+
/*
* Intel 82801CAM ICH3-M datasheet says IDE modes must be the same
*/
--
Ben (ben@fluff.org, http://www.fluff.org/)
'a smiley only costs 4 bytes'
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: PCI: Add ALI M5229 comaptibility mode quirk
2008-09-12 11:22 PCI: Add ALI M5229 comaptibility mode quirk Ben Dooks
@ 2008-09-12 12:33 ` Matthew Wilcox
2008-09-12 13:00 ` Ben Dooks
2008-09-13 14:24 ` Jeff Garzik
1 sibling, 1 reply; 8+ messages in thread
From: Matthew Wilcox @ 2008-09-12 12:33 UTC (permalink / raw)
To: Ben Dooks; +Cc: linux-kernel, linux-pci, linux-ide
On Fri, Sep 12, 2008 at 12:22:52PM +0100, Ben Dooks wrote:
> The libata driver will not work with an M5229 set into native IDE
> mode (the old drivers/pci one does) if the M5229 does not provide
> it's own IRQ.
>
> The M5229 implementation embedded into the ALI M1543 uses the
> M1543's ISA PIC to provide the interrupts and thus does not have
> an valid PCI IRQ set. This quirk detects the abscence of IRQ and
> sets the M5229 back into compatibility mode to use IRQs 14 and 15
> so that libata works correctly.
>
> Note, I belive that the check for an valid interrupt line is
> correct, I only have an M5229 in an ALI M1543 to check this
> on. It would be useful to confirm that a M5229 with an valid IRQ
> does not trigger this quirk.
Why does this need to be a quirk rather than something in the libata ALi
driver?
> Signed-off-by: Ben Dooks <ben-linux@fluff.org>
>
> Index: linux-2.6.27-rc6-cats1/drivers/pci/quirks.c
> ===================================================================
> --- linux-2.6.27-rc6-cats1.orig/drivers/pci/quirks.c 2008-09-11 11:26:35.000000000 +0100
> +++ linux-2.6.27-rc6-cats1/drivers/pci/quirks.c 2008-09-12 12:18:05.000000000 +0100
> @@ -905,6 +905,34 @@ static void __devinit quirk_svwks_csb5id
> }
> DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_SERVERWORKS, PCI_DEVICE_ID_SERVERWORKS_CSB5IDE, quirk_svwks_csb5ide);
>
> +/* Some systems set the ALI M5229 in the ALI M1543 bridge to native mode,
> + * which cannot be supported by the pata_ali.c driver (the old drivers/ide
> + * makes a compatibility effort to change the IDE interrupts).
> + */
> +static void __devinit quirk_ali_ide_compatibility(struct pci_dev *pdev)
> +{
> + u8 tmp;
> +
> + /* pdev->irq and pdev->pin have yet to be initialised, so check
> + * by reading from the configuration header to see if we've got
> + * a valid interrupt line. */
> +
> + pci_read_config_byte(pdev, PCI_INTERRUPT_LINE, &tmp);
> + if (tmp != 0xff)
> + return;
> +
> + pci_read_config_byte(pdev, PCI_CLASS_PROG, &tmp);
> + if (tmp & 0x5) {
> + dev_info(&pdev->dev, "quirk: changing to IDE compatibility mode\n");
> +
> + tmp &= ~0x05;
> + pdev->class &= ~0x05;
> + pci_write_config_byte(pdev, PCI_CLASS_PROG, tmp);
> + }
> +}
> +
> +DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_AL, PCI_DEVICE_ID_AL_M5229, quirk_ali_ide_compatibility);
> +
> /*
> * Intel 82801CAM ICH3-M datasheet says IDE modes must be the same
> */
>
> --
> Ben (ben@fluff.org, http://www.fluff.org/)
>
> 'a smiley only costs 4 bytes'
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Matthew Wilcox Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: PCI: Add ALI M5229 comaptibility mode quirk
2008-09-12 12:33 ` Matthew Wilcox
@ 2008-09-12 13:00 ` Ben Dooks
2008-09-12 13:26 ` Matthew Wilcox
0 siblings, 1 reply; 8+ messages in thread
From: Ben Dooks @ 2008-09-12 13:00 UTC (permalink / raw)
To: Matthew Wilcox; +Cc: Ben Dooks, linux-kernel, linux-pci, linux-ide
On Fri, Sep 12, 2008 at 06:33:40AM -0600, Matthew Wilcox wrote:
> On Fri, Sep 12, 2008 at 12:22:52PM +0100, Ben Dooks wrote:
> > The libata driver will not work with an M5229 set into native IDE
> > mode (the old drivers/pci one does) if the M5229 does not provide
> > it's own IRQ.
> >
> > The M5229 implementation embedded into the ALI M1543 uses the
> > M1543's ISA PIC to provide the interrupts and thus does not have
> > an valid PCI IRQ set. This quirk detects the abscence of IRQ and
> > sets the M5229 back into compatibility mode to use IRQs 14 and 15
> > so that libata works correctly.
> >
> > Note, I belive that the check for an valid interrupt line is
> > correct, I only have an M5229 in an ALI M1543 to check this
> > on. It would be useful to confirm that a M5229 with an valid IRQ
> > does not trigger this quirk.
>
> Why does this need to be a quirk rather than something in the libata ALi
> driver?
The short answer is that "Alan Cox says not in libata", the longer
one can be found:
http://www.archivum.info/linux-ide@vger.kernel.org/2008-07/msg00410.html
> > Signed-off-by: Ben Dooks <ben-linux@fluff.org>
> >
> > Index: linux-2.6.27-rc6-cats1/drivers/pci/quirks.c
> > ===================================================================
> > --- linux-2.6.27-rc6-cats1.orig/drivers/pci/quirks.c 2008-09-11 11:26:35.000000000 +0100
> > +++ linux-2.6.27-rc6-cats1/drivers/pci/quirks.c 2008-09-12 12:18:05.000000000 +0100
> > @@ -905,6 +905,34 @@ static void __devinit quirk_svwks_csb5id
> > }
> > DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_SERVERWORKS, PCI_DEVICE_ID_SERVERWORKS_CSB5IDE, quirk_svwks_csb5ide);
> >
> > +/* Some systems set the ALI M5229 in the ALI M1543 bridge to native mode,
> > + * which cannot be supported by the pata_ali.c driver (the old drivers/ide
> > + * makes a compatibility effort to change the IDE interrupts).
> > + */
> > +static void __devinit quirk_ali_ide_compatibility(struct pci_dev *pdev)
> > +{
> > + u8 tmp;
> > +
> > + /* pdev->irq and pdev->pin have yet to be initialised, so check
> > + * by reading from the configuration header to see if we've got
> > + * a valid interrupt line. */
> > +
> > + pci_read_config_byte(pdev, PCI_INTERRUPT_LINE, &tmp);
> > + if (tmp != 0xff)
> > + return;
> > +
> > + pci_read_config_byte(pdev, PCI_CLASS_PROG, &tmp);
> > + if (tmp & 0x5) {
> > + dev_info(&pdev->dev, "quirk: changing to IDE compatibility mode\n");
> > +
> > + tmp &= ~0x05;
> > + pdev->class &= ~0x05;
> > + pci_write_config_byte(pdev, PCI_CLASS_PROG, tmp);
> > + }
> > +}
> > +
> > +DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_AL, PCI_DEVICE_ID_AL_M5229, quirk_ali_ide_compatibility);
> > +
> > /*
> > * Intel 82801CAM ICH3-M datasheet says IDE modes must be the same
> > */
> >
> > --
> > Ben (ben@fluff.org, http://www.fluff.org/)
> >
> > 'a smiley only costs 4 bytes'
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
>
> --
> Matthew Wilcox Intel Open Source Technology Centre
> "Bill, look, we understand that you're interested in selling us this
> operating system, but compare it to ours. We can't possibly take such
> a retrograde step."
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ide" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
--
Ben
Q: What's a light-year?
A: One-third less calories than a regular year.
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: PCI: Add ALI M5229 comaptibility mode quirk
2008-09-12 13:00 ` Ben Dooks
@ 2008-09-12 13:26 ` Matthew Wilcox
2008-09-12 13:42 ` Ben Dooks
0 siblings, 1 reply; 8+ messages in thread
From: Matthew Wilcox @ 2008-09-12 13:26 UTC (permalink / raw)
To: Ben Dooks; +Cc: linux-kernel, linux-pci, linux-ide, Alan Cox
On Fri, Sep 12, 2008 at 02:00:43PM +0100, Ben Dooks wrote:
> On Fri, Sep 12, 2008 at 06:33:40AM -0600, Matthew Wilcox wrote:
> > On Fri, Sep 12, 2008 at 12:22:52PM +0100, Ben Dooks wrote:
> > > The M5229 implementation embedded into the ALI M1543 uses the
> > > M1543's ISA PIC to provide the interrupts and thus does not have
> > > an valid PCI IRQ set. This quirk detects the abscence of IRQ and
> > > sets the M5229 back into compatibility mode to use IRQs 14 and 15
> > > so that libata works correctly.
> >
> > Why does this need to be a quirk rather than something in the libata ALi
> > driver?
>
> The short answer is that "Alan Cox says not in libata", the longer
> one can be found:
>
> http://www.archivum.info/linux-ide@vger.kernel.org/2008-07/msg00410.html
Thanks for the reference. I've now read that thread. I'm not entirely
convinced Alan is right; I think it's preferable to confine this
quirking to the driver and fix up the BARs in the driver as well.
--
Matthew Wilcox Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: PCI: Add ALI M5229 comaptibility mode quirk
2008-09-12 13:26 ` Matthew Wilcox
@ 2008-09-12 13:42 ` Ben Dooks
0 siblings, 0 replies; 8+ messages in thread
From: Ben Dooks @ 2008-09-12 13:42 UTC (permalink / raw)
To: Matthew Wilcox; +Cc: Ben Dooks, linux-kernel, linux-pci, linux-ide, Alan Cox
On Fri, Sep 12, 2008 at 07:26:37AM -0600, Matthew Wilcox wrote:
> On Fri, Sep 12, 2008 at 02:00:43PM +0100, Ben Dooks wrote:
> > On Fri, Sep 12, 2008 at 06:33:40AM -0600, Matthew Wilcox wrote:
> > > On Fri, Sep 12, 2008 at 12:22:52PM +0100, Ben Dooks wrote:
> > > > The M5229 implementation embedded into the ALI M1543 uses the
> > > > M1543's ISA PIC to provide the interrupts and thus does not have
> > > > an valid PCI IRQ set. This quirk detects the abscence of IRQ and
> > > > sets the M5229 back into compatibility mode to use IRQs 14 and 15
> > > > so that libata works correctly.
> > >
> > > Why does this need to be a quirk rather than something in the libata ALi
> > > driver?
> >
> > The short answer is that "Alan Cox says not in libata", the longer
> > one can be found:
> >
> > http://www.archivum.info/linux-ide@vger.kernel.org/2008-07/msg00410.html
>
> Thanks for the reference. I've now read that thread. I'm not entirely
> convinced Alan is right; I think it's preferable to confine this
> quirking to the driver and fix up the BARs in the driver as well.
I'm not convinced by that, I've no idea how that will affect the system
moving PCI BARs after the fact.
> --
> Matthew Wilcox Intel Open Source Technology Centre
> "Bill, look, we understand that you're interested in selling us this
> operating system, but compare it to ours. We can't possibly take such
> a retrograde step."
--
--
Ben
Q: What's a light-year?
A: One-third less calories than a regular year.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: PCI: Add ALI M5229 comaptibility mode quirk
2008-09-12 11:22 PCI: Add ALI M5229 comaptibility mode quirk Ben Dooks
2008-09-12 12:33 ` Matthew Wilcox
@ 2008-09-13 14:24 ` Jeff Garzik
2008-09-14 20:46 ` Ben Dooks
1 sibling, 1 reply; 8+ messages in thread
From: Jeff Garzik @ 2008-09-13 14:24 UTC (permalink / raw)
To: Ben Dooks; +Cc: linux-kernel, linux-pci, Linux IDE mailing list, Alan Cox
Ben Dooks wrote:
> The libata driver will not work with an M5229 set into native IDE
> mode (the old drivers/pci one does) if the M5229 does not provide
> it's own IRQ.
>
> The M5229 implementation embedded into the ALI M1543 uses the
> M1543's ISA PIC to provide the interrupts and thus does not have
> an valid PCI IRQ set. This quirk detects the abscence of IRQ and
> sets the M5229 back into compatibility mode to use IRQs 14 and 15
> so that libata works correctly.
>
> Note, I belive that the check for an valid interrupt line is
> correct, I only have an M5229 in an ALI M1543 to check this
> on. It would be useful to confirm that a M5229 with an valid IRQ
> does not trigger this quirk.
>
> Signed-off-by: Ben Dooks <ben-linux@fluff.org>
>
> Index: linux-2.6.27-rc6-cats1/drivers/pci/quirks.c
> ===================================================================
> --- linux-2.6.27-rc6-cats1.orig/drivers/pci/quirks.c 2008-09-11 11:26:35.000000000 +0100
> +++ linux-2.6.27-rc6-cats1/drivers/pci/quirks.c 2008-09-12 12:18:05.000000000 +0100
> @@ -905,6 +905,34 @@ static void __devinit quirk_svwks_csb5id
> }
> DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_SERVERWORKS, PCI_DEVICE_ID_SERVERWORKS_CSB5IDE, quirk_svwks_csb5ide);
>
> +/* Some systems set the ALI M5229 in the ALI M1543 bridge to native mode,
> + * which cannot be supported by the pata_ali.c driver (the old drivers/ide
> + * makes a compatibility effort to change the IDE interrupts).
> + */
> +static void __devinit quirk_ali_ide_compatibility(struct pci_dev *pdev)
> +{
> + u8 tmp;
> +
> + /* pdev->irq and pdev->pin have yet to be initialised, so check
> + * by reading from the configuration header to see if we've got
> + * a valid interrupt line. */
> +
> + pci_read_config_byte(pdev, PCI_INTERRUPT_LINE, &tmp);
> + if (tmp != 0xff)
> + return;
> +
> + pci_read_config_byte(pdev, PCI_CLASS_PROG, &tmp);
> + if (tmp & 0x5) {
> + dev_info(&pdev->dev, "quirk: changing to IDE compatibility mode\n");
> +
> + tmp &= ~0x05;
> + pdev->class &= ~0x05;
> + pci_write_config_byte(pdev, PCI_CLASS_PROG, tmp);
> + }
> +}
> +
> +DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_AL, PCI_DEVICE_ID_AL_M5229, quirk_ali_ide_compatibility);
This is a bit surprising, considering that libata works for all IDE mode
of other controllers...
Jeff
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: PCI: Add ALI M5229 comaptibility mode quirk
2008-09-13 14:24 ` Jeff Garzik
@ 2008-09-14 20:46 ` Ben Dooks
0 siblings, 0 replies; 8+ messages in thread
From: Ben Dooks @ 2008-09-14 20:46 UTC (permalink / raw)
To: Jeff Garzik
Cc: Ben Dooks, linux-kernel, linux-pci, Linux IDE mailing list,
Alan Cox
On Sat, Sep 13, 2008 at 10:24:29AM -0400, Jeff Garzik wrote:
> Ben Dooks wrote:
>> The libata driver will not work with an M5229 set into native IDE
>> mode (the old drivers/pci one does) if the M5229 does not provide
>> it's own IRQ.
>>
>> The M5229 implementation embedded into the ALI M1543 uses the
>> M1543's ISA PIC to provide the interrupts and thus does not have
>> an valid PCI IRQ set. This quirk detects the abscence of IRQ and
>> sets the M5229 back into compatibility mode to use IRQs 14 and 15
>> so that libata works correctly.
>>
>> Note, I belive that the check for an valid interrupt line is
>> correct, I only have an M5229 in an ALI M1543 to check this
>> on. It would be useful to confirm that a M5229 with an valid IRQ
>> does not trigger this quirk.
>>
>> Signed-off-by: Ben Dooks <ben-linux@fluff.org>
>>
>> Index: linux-2.6.27-rc6-cats1/drivers/pci/quirks.c
>> ===================================================================
>> --- linux-2.6.27-rc6-cats1.orig/drivers/pci/quirks.c 2008-09-11 11:26:35.000000000 +0100
>> +++ linux-2.6.27-rc6-cats1/drivers/pci/quirks.c 2008-09-12 12:18:05.000000000 +0100
>> @@ -905,6 +905,34 @@ static void __devinit quirk_svwks_csb5id
>> }
>> DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_SERVERWORKS, PCI_DEVICE_ID_SERVERWORKS_CSB5IDE, quirk_svwks_csb5ide);
>> +/* Some systems set the ALI M5229 in the ALI M1543 bridge to native
>> mode,
>> + * which cannot be supported by the pata_ali.c driver (the old drivers/ide
>> + * makes a compatibility effort to change the IDE interrupts).
>> + */
>> +static void __devinit quirk_ali_ide_compatibility(struct pci_dev *pdev)
>> +{
>> + u8 tmp;
>> +
>> + /* pdev->irq and pdev->pin have yet to be initialised, so check
>> + * by reading from the configuration header to see if we've got
>> + * a valid interrupt line. */
>> +
>> + pci_read_config_byte(pdev, PCI_INTERRUPT_LINE, &tmp);
>> + if (tmp != 0xff)
>> + return;
>> +
>> + pci_read_config_byte(pdev, PCI_CLASS_PROG, &tmp);
>> + if (tmp & 0x5) {
>> + dev_info(&pdev->dev, "quirk: changing to IDE compatibility mode\n");
>> +
>> + tmp &= ~0x05;
>> + pdev->class &= ~0x05;
>> + pci_write_config_byte(pdev, PCI_CLASS_PROG, tmp);
>> + }
>> +}
>> +
>> +DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_AL, PCI_DEVICE_ID_AL_M5229, quirk_ali_ide_compatibility);
>
>
> This is a bit surprising, considering that libata works for all IDE mode
> of other controllers...
The problem is that when the M5229 is embedded into an M1543, the
PCI IRQ is ignored, and the IRQ is routed directly into the ISA-PIC
in the M1543. This routing is done via a different set of configuration
registers, so that each channel can have its own IRQ.
This means that in pci-native mode, there is no pcidev.irq field set,
as there is no PCI IRQ setup. Alan Cox has stated that this is too
broken to be worked around in libata.
--
Ben (ben@fluff.org, http://www.fluff.org/)
'a smiley only costs 4 bytes'
^ permalink raw reply [flat|nested] 8+ messages in thread
[parent not found: <fa.5x39Eh02m9rtrn5GDRnZ3IcV/z8@ifi.uio.no>]
end of thread, other threads:[~2008-09-14 20:47 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-09-12 11:22 PCI: Add ALI M5229 comaptibility mode quirk Ben Dooks
2008-09-12 12:33 ` Matthew Wilcox
2008-09-12 13:00 ` Ben Dooks
2008-09-12 13:26 ` Matthew Wilcox
2008-09-12 13:42 ` Ben Dooks
2008-09-13 14:24 ` Jeff Garzik
2008-09-14 20:46 ` Ben Dooks
[not found] <fa.5x39Eh02m9rtrn5GDRnZ3IcV/z8@ifi.uio.no>
[not found] ` <fa.bfF4DSr1eMYmEl5E90sppi2wbuU@ifi.uio.no>
2008-09-13 17:31 ` Robert Hancock
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox