From: David Brownell <david-b@pacbell.net>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Steven Noonan <steven.noonan@uplinklabs.net>,
Andrew Morton <akpm@linux-foundation.org>,
Kernel development list <linux-kernel@vger.kernel.org>,
Steven Noonan <steven@uplinklabs.net>,
USB list <linux-usb@vger.kernel.org>
Subject: Re: [PATCH 1/1] drivers/usb/host/pci-quirks.c: wait for EHCI handoff far too long in quirk_usb_disable_ehci()
Date: Fri, 12 Sep 2008 16:28:59 -0700 [thread overview]
Message-ID: <200809121628.59900.david-b@pacbell.net> (raw)
In-Reply-To: <Pine.LNX.4.44L0.0809091011250.2486-100000@iolanthe.rowland.org>
On Tuesday 09 September 2008, Alan Stern wrote:
> > >
> > > The delay in the current version of pci-quirks.c is 5 seconds,
> > > which I've cut down to 0.5 seconds.
>
> > I guess it risks breaking someone else's system. Or perhaps the number
> > was just grabbed out of the air.
>
> As far as I know, it was indeed just grabbed out of the air. The spec
> specifically avoids giving an upper limit on how long to wait.
>
> > Can we do a separate quirk just for that machine (and ones with the
> > same bug)?
>
> My BIOS has the same bug. I wouldn't mind seeing the delay reduced.
I'm fairly sure that someone's system needed more than 1/2 second.
And that going from 500 to 5000 was the obvious "add a zero" way
to get to a long-enough timeout.
prev parent reply other threads:[~2008-09-12 23:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-07 0:29 [PATCH 0/1] EHCI handoff failure timeout too long Steven Noonan
2008-09-07 0:29 ` [PATCH 1/1] drivers/usb/host/pci-quirks.c: wait for EHCI handoff far too long in quirk_usb_disable_ehci() Steven Noonan
2008-09-09 4:44 ` Andrew Morton
2008-09-09 14:13 ` Alan Stern
2008-09-12 23:28 ` David Brownell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200809121628.59900.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=steven.noonan@uplinklabs.net \
--cc=steven@uplinklabs.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox