From: Andi Kleen <andi@firstfloor.org>
To: Yinghai Lu <yhlu.kernel@gmail.com>
Cc: Andi Kleen <andi@firstfloor.org>,
Thomas Gleixner <tglx@linutronix.de>,
Andrew Morton <akpm@linux-foundation.org>,
mingo@elte.hu, hpa@zytor.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] apci: dump slit
Date: Sat, 13 Sep 2008 00:29:28 +0200 [thread overview]
Message-ID: <20080912222928.GB11730@one.firstfloor.org> (raw)
In-Reply-To: <86802c440809121454v5302d79ds8c6e1e6ca948059a@mail.gmail.com>
On Fri, Sep 12, 2008 at 02:54:12PM -0700, Yinghai Lu wrote:
> On Fri, Sep 12, 2008 at 2:30 PM, Andi Kleen <andi@firstfloor.org> wrote:
> >
> > Yes excellent point. Should we dump the complete ACPI tables?
> > Do you prefer hexdump
>
> good point. there is one time BIOS put blank slit there. (only have
> acpi table header)
> only after dump that earlier in kernel boot log, they shut up and go
> back to fix their problem.
You should have asked them to run firmwaretestkit (and if fwtestkit
doesn't test for a correct SLIT fix it there). That is what
it is for. But adding it
to all Linux bootlogs ever just for this special case is the wrong way.
-Andi
--
ak@linux.intel.com
next prev parent reply other threads:[~2008-09-12 22:25 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-12 18:17 [PATCH] apci: dump slit Yinghai Lu
2008-09-12 19:20 ` Andrew Morton
2008-09-12 19:29 ` Yinghai Lu
2008-09-12 20:13 ` H. Peter Anvin
2008-09-12 21:17 ` Andi Kleen
2008-09-12 21:44 ` Thomas Gleixner
2008-09-12 21:11 ` Andi Kleen
2008-09-12 21:19 ` Thomas Gleixner
2008-09-12 21:30 ` Andi Kleen
2008-09-12 21:41 ` Matt Keenan
2008-09-12 21:49 ` Thomas Gleixner
2008-09-12 22:14 ` Andi Kleen
2008-09-12 21:54 ` Yinghai Lu
2008-09-12 22:29 ` Andi Kleen [this message]
2008-09-14 11:22 ` Pavel Machek
2008-09-14 12:26 ` Ingo Molnar
2008-09-14 15:59 ` Pavel Machek
2008-09-14 16:00 ` Pavel Machek
2008-09-14 16:04 ` Ingo Molnar
2008-09-14 18:13 ` Yinghai Lu
2008-09-18 18:26 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080912222928.GB11730@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=yhlu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox