Re: [PATCH] Fixup deb-pkg target to generate separate firmware deb.

[Frans Pop <elendil@planet.nl>]

On Friday 12 September 2008, Jonathan McDowell wrote:
> The below is a simplistic fix for "make deb-pkg"; it splits the
> firmware out to a linux-firmware-image package and adds an
> (unversioned) Suggests to the linux package for this firmware.
>
> Frans, does this solve your problem in an acceptable manner?

Yes it does. Thanks for the patch Jonathan.
Tested both with kernel configs that result in firmware and that do not 
result in firmware.

A few minor nitpicks below.

> Signed-Off-By: Jonathan McDowell <noodles@earth.li>

Acked-by: Frans Pop <elendil@planet.nl>

> @@ -118,8 +122,24 @@ fi 
>  chown -R root:root "$tmpdir"
>  chmod -R go-w "$tmpdir"
>
> +# Do we have firmware? Move it out of the way and build it into a
> package. +if [ -e "$tmpdir/lib/firmware" ]; then
> +	mv "$tmpdir/lib/firmware" "$fwdir/lib/"
> +
> +cat <<EOF >> debian/control

This line should be indented one level.

> +
> +Package: $fwpackagename
> +Architecture: any
> +Description: Linux kernel firmware, version $version
> + This package contains firmware from the Linux kernel, version
> $version
> +EOF 
> +
> +dpkg-gencontrol -isp -p$fwpackagename -P"$fwdir"
> +dpkg --build "$fwdir" ..

Same for these two lines.

> +fi
> +
>  # Perform the final magic
> -dpkg-gencontrol -isp
> +dpkg-gencontrol -isp -p$packagename
>  dpkg --build "$tmpdir" ..
>
>  exit 0
> -----
>
> J.