From: Ingo Molnar <mingo@elte.hu>
To: Raz <raziebe@gmail.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
linux-acpi@vger.kernel.org, carlos@strangeworlds.co.uk,
Vegard Nossum <vegard.nossum@gmail.com>,
Pekka Paalanen <pq@iki.fi>,
Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
Subject: Re: Subject: [PATCH] linux-acpi: smp_alternatives sleeping in spinlock
Date: Sun, 14 Sep 2008 15:18:18 +0200 [thread overview]
Message-ID: <20080914131818.GA30643@elte.hu> (raw)
In-Reply-To: <5d96567b0809130652i7bc86cbfv6cdc103f595e1e11@mail.gmail.com>
* Raz <raziebe@gmail.com> wrote:
> From: Raz Ben Yehuda <raziebe@gmail.com>
>
> When booting a kernel with PREEMPT_ENABLE and SLAB_DEBUG, unplugging a
> processor results in BUG in slab.
could you please post that BUG? (and which version of the kernel you
have tried, and exactly what you did to trigger this bug)
note that the conversion to a sleeping lock:
> -static DEFINE_SPINLOCK(smp_alt);
> +static __DECLARE_SEMAPHORE_GENERIC(smp_alt_lock, 1);
is already done correctly in the latest upstream kernel, see this
commit:
# 2f1dafe: x86: fix SMP alternatives: use mutex instead of spinlock
the better solution is to use a mutex, not a semaphore. This fix is part
of the v2.6.26 kernel.
Ingo
next prev parent reply other threads:[~2008-09-14 13:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-13 13:52 Subject: [PATCH] linux-acpi: smp_alternatives sleeping in spinlock Raz
2008-09-14 13:18 ` Ingo Molnar [this message]
2008-09-14 13:37 ` Raz
2008-09-14 13:42 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080914131818.GA30643@elte.hu \
--to=mingo@elte.hu \
--cc=carlos@strangeworlds.co.uk \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=pq@iki.fi \
--cc=raziebe@gmail.com \
--cc=vegard.nossum@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox