From: Ingo Molnar <mingo@elte.hu>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: "Maciej W. Rozycki" <macro@linux-mips.org>,
LKML <linux-kernel@vger.kernel.org>,
Yinghai Lu <yhlu.kernel@gmail.com>
Subject: Re: [PATCH] x86: smpboot - check if we have ESR register in wakeup_secondary_cpu
Date: Mon, 15 Sep 2008 09:56:55 +0200 [thread overview]
Message-ID: <20080915075655.GC29585@elte.hu> (raw)
In-Reply-To: <20080914175849.GC3907@lenovo>
* Cyrill Gorcunov <gorcunov@gmail.com> wrote:
> We should check if we have ESR register before writting to it.
>
> Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
> ---
>
> Please review!
> it seems the same nit in do_boot_cpu - checking now.
>
> Index: linux-2.6.git/arch/x86/kernel/smpboot.c
> ===================================================================
> --- linux-2.6.git.orig/arch/x86/kernel/smpboot.c 2008-09-14 19:43:03.000000000 +0400
> +++ linux-2.6.git/arch/x86/kernel/smpboot.c 2008-09-14 21:49:36.000000000 +0400
> @@ -598,10 +598,12 @@ wakeup_secondary_cpu(int logical_apicid,
> * Give the other CPU some time to accept the IPI.
> */
> udelay(200);
> - maxlvt = lapic_get_maxlvt();
> - if (maxlvt > 3) /* Due to the Pentium erratum 3AP. */
> - apic_write(APIC_ESR, 0);
> - accept_status = (apic_read(APIC_ESR) & 0xEF);
> + if (APIC_INTEGRATED(apic_version[phys_apicid])) {
> + maxlvt = lapic_get_maxlvt();
> + if (maxlvt > 3) /* Due to the Pentium erratum 3AP. */
> + apic_write(APIC_ESR, 0);
> + accept_status = (apic_read(APIC_ESR) & 0xEF);
> + }
> pr_debug("NMI sent.\n");
hm, is there any non-integrated lapic that has more than 3 lvts? iirc
lvts were introduced with the integrated lapic.
Ingo
next prev parent reply other threads:[~2008-09-15 7:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-14 17:58 [PATCH] x86: smpboot - check if we have ESR register in wakeup_secondary_cpu Cyrill Gorcunov
2008-09-15 7:56 ` Ingo Molnar [this message]
2008-09-15 10:01 ` Cyrill Gorcunov
2008-09-15 10:20 ` Cyrill Gorcunov
2008-09-15 14:02 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080915075655.GC29585@elte.hu \
--to=mingo@elte.hu \
--cc=gorcunov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=macro@linux-mips.org \
--cc=yhlu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox