From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755973AbYIOTBl (ORCPT ); Mon, 15 Sep 2008 15:01:41 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753207AbYIOTB2 (ORCPT ); Mon, 15 Sep 2008 15:01:28 -0400 Received: from ns.suse.de ([195.135.220.2]:47928 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753006AbYIOTB1 (ORCPT ); Mon, 15 Sep 2008 15:01:27 -0400 Date: Mon, 15 Sep 2008 11:55:55 -0700 From: Greg KH To: Randy Dunlap Cc: Hannes Reinecke , Adrian Bunk , Kay Sievers , Stephen Rothwell , linux-next@vger.kernel.org, LKML , netdev Subject: Re: linux-next: Tree for September 13 (3c509) Message-ID: <20080915185555.GA31996@suse.de> References: <20080913162344.ab395285.sfr@canb.auug.org.au> <20080914141757.899f71eb.randy.dunlap@oracle.com> <20080915141149.GA10002@cs181140183.pp.htv.fi> <48CE70CC.7020901@suse.de> <20080915080357.2eaae073.randy.dunlap@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080915080357.2eaae073.randy.dunlap@oracle.com> User-Agent: Mutt/1.5.16 (2007-06-09) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 15, 2008 at 08:03:57AM -0700, Randy Dunlap wrote: > On Mon, 15 Sep 2008 16:27:24 +0200 Hannes Reinecke wrote: > > > Hi Adrian, > > > > Adrian Bunk wrote: > > > On Sun, Sep 14, 2008 at 02:17:57PM -0700, Randy Dunlap wrote: > > >> drivers/net/3c509.c fails (CONFIG_PM=y) with: > > >> > > >> drivers/built-in.o:(.data+0x7dcc): undefined reference to `el3_resume' > > >> drivers/built-in.o:(.data+0x7e08): undefined reference to `el3_resume' > > >> > > >> It seems that this function does not exist in the source file. > > > > > > > > > It got removed by: > > > > > > > > > commit 107aeb9753159da848f066b26557f0aaab900a90 > > > Author: Hannes Reinecke > > > Date: Wed Sep 10 14:16:04 2008 +0200 > > > > > > Driver core: Use dev_get_drvdata() accessors > > > > > > Deprecated direct access to the ->driver_data field and > > > use accessors throughout. > > > > > > Signed-off-by: Hannes Reinecke > > > Cc: Kay Sievers > > > Signed-off-by: Greg Kroah-Hartman > > > > > Sorry. Here it is again. > > Ack, that [attached] patch fixes the build. Now merged in with Hannes's original patch. thanks, greg k-h