From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756053AbYIOScy (ORCPT ); Mon, 15 Sep 2008 14:32:54 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753440AbYIOScL (ORCPT ); Mon, 15 Sep 2008 14:32:11 -0400 Received: from rv-out-0506.google.com ([209.85.198.226]:6991 "EHLO rv-out-0506.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753302AbYIOScI (ORCPT ); Mon, 15 Sep 2008 14:32:08 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:subject:date:user-agent:cc:references:in-reply-to :mime-version:content-disposition:message-id:content-type :content-transfer-encoding; b=IvzUn3um55qT0rkqRTeJCGPd0IboRb1to5S+7tATxTTwjubwBmB1dfEab/M8bWgF2/ zpPA55Wmr8/anWTqYL178Q+AdtO0qkUqt79jkTl3TEGEbcR3Rp+v9gNn9nsjtcp5xsBt knARJU8Nr6KAheqgUwyiWvBLUVHNCYo0VUZFk= From: Bartlomiej Zolnierkiewicz To: Borislav Petkov Subject: Re: [PATCH 05/10] ide-atapi: accomodate transfer length to ide-cd Date: Mon, 15 Sep 2008 20:15:11 +0200 User-Agent: KMail/1.9.9 Cc: linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org, Borislav Petkov References: <1221392158-3848-1-git-send-email-petkovbb@gmail.com> <1221392158-3848-6-git-send-email-petkovbb@gmail.com> In-Reply-To: <1221392158-3848-6-git-send-email-petkovbb@gmail.com> MIME-Version: 1.0 Content-Disposition: inline Message-Id: <200809152015.12602.bzolnier@gmail.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sunday 14 September 2008 13:35:53 Borislav Petkov wrote: > There should be no functional change resulting from this patch. > > Signed-off-by: Borislav Petkov > --- > drivers/ide/ide-atapi.c | 4 +++- > drivers/ide/ide-floppy.c | 2 +- > drivers/ide/ide-tape.c | 2 +- > drivers/scsi/ide-scsi.c | 3 ++- > include/linux/ide.h | 2 +- > 5 files changed, 8 insertions(+), 5 deletions(-) > > diff --git a/drivers/ide/ide-atapi.c b/drivers/ide/ide-atapi.c > index df17401..7045d34 100644 > --- a/drivers/ide/ide-atapi.c > +++ b/drivers/ide/ide-atapi.c > @@ -546,7 +546,7 @@ static ide_startstop_t ide_transfer_pc(ide_drive_t *drive) > } > > ide_startstop_t ide_issue_pc(ide_drive_t *drive, unsigned int timeout, > - ide_expiry_t *expiry) > + ide_expiry_t *expiry, int xferlen) > { > struct ide_atapi_pc *pc = drive->pc; > ide_hwif_t *hwif = drive->hwif; > @@ -561,6 +561,8 @@ ide_startstop_t ide_issue_pc(ide_drive_t *drive, unsigned int timeout, > /* Request to transfer the entire buffer at once */ > if (drive->media == ide_tape && scsi == 0) > bcount = pc->req_xfer; > + else if (drive->media == ide_cdrom || drive->media == ide_optical) > + bcount = xferlen; > else > bcount = min(pc->req_xfer, 63 * 1024); If you move info->last_block to ide_drive_t it is possible to factor out xferlen setup from ide_cd_do_request() to a separate handler and move it here. Then xferlen argument to ide_issue_pc() won't be necessary. How's about it?