Re: [PATCH 07/10] ide-atapi: prepare ide-cd expiry handler

Bartlomiej Zolnierkiewicz
2008-09-15T18:33:55Z

On Sunday 14 September 2008 13:35:55 Borislav Petkov wrote:
> Push ide-cd expiry handler into the ide-cd header. Also, pass expiry
> handler to ide_execute_command() in ide_issue_pc() for later.

Uh, no. Please don't include "ide-cd.h" in ide-atapi.c. Instead just move
the expiry handler to ide-atapi.c like it was done with ide_scsi_expiry().

It also seems that 'expiry' argument is not needed and expiry handler
to use can be deduced from drive->media and drive->scsi.

patches #8-10 look OK on the quick look but since they depend on
earlier changes they also need to be updated.