Re: [PATCH 1/7] dynamic debug v2 - infrastructure

Dominik Brodowski
2008-07-18T06:37:36Z

On Thu, Jul 17, 2008 at 04:35:24PM -0700, Greg KH wrote:
> > <sysfs>/module/<module_name>/debug/{enabled[,level][,flag]}
>
> I like this as that is what a number of current modules do (usb-serial
> drivers), but you have to be careful about the module parameter
> namespace to not get collisions here with existing "debug" files.

That's why I'd put it into a different namespace (debug instead of
parameters).

> So for now, I recommend staying in debugfs, it makes more sense.

ACK.

Best,
Dominik