From: Andi Kleen <andi@firstfloor.org>
To: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Cc: andi@firstfloor.org, mingo@elte.hu, joerg.roedel@amd.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] fix GART to respect device's dma_mask about virtual mappings
Date: Tue, 16 Sep 2008 15:43:35 +0200 [thread overview]
Message-ID: <20080916134335.GC25711@one.firstfloor.org> (raw)
In-Reply-To: <20080916222032O.fujita.tomonori@lab.ntt.co.jp>
> What the need_iommu() does is seeing if GART needs to do virtual
> mappings or not.
>
> (After need_iommu() checking) What this patchset does is to guarantee
> that GART provides a virtual address that a device can access to.
Ah you care about masks < 32bit?
Those always are handled elsewhere in the block layer (using the bounce_pfn
mechanism) or in various other ways in other subsystems. e.g. on networking
the rule is that you just don't announce direct SG when you have
less than 32bit mask. And the others like sound generally don't use
map_sg()/map_single(), but instead pre allocate something with
dma_alloc_coherent() or similar.
Also what would you do if it this check fails? There is no suitable
fallback path.
Can you describe a concrete use case your patch fixes?
Anyways I'm aware the semantics are a little non untuitive (I didn't
invent them, but inherited them from other 64bit IOMMU implementations),
but fully general handling of < 32bit masks would be extremly complicated
because you would always need to have a full arbitary fallback
swiotlb implemention that is able to allocate arbitary low memory.
-Andi
next prev parent reply other threads:[~2008-09-16 13:39 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-12 10:42 [PATCH 0/3] fix GART to respect device's dma_mask about virtual mappings FUJITA Tomonori
2008-09-12 10:42 ` [PATCH 1/3] add iommu_device_max_index IOMMU helper function FUJITA Tomonori
2008-09-12 10:42 ` [PATCH 2/3] add dma_get_mask " FUJITA Tomonori
2008-09-12 10:42 ` [PATCH 3/3] x86: make GART to respect device's dma_mask about virtual mappings FUJITA Tomonori
2008-09-12 14:52 ` Joerg Roedel
2008-09-12 15:11 ` FUJITA Tomonori
2008-09-14 14:45 ` [PATCH 0/3] fix " Ingo Molnar
2008-09-16 0:54 ` Andi Kleen
2008-09-16 13:20 ` FUJITA Tomonori
2008-09-16 13:43 ` Andi Kleen [this message]
2008-09-16 17:13 ` FUJITA Tomonori
2008-09-16 17:58 ` Andi Kleen
2008-09-16 23:53 ` FUJITA Tomonori
2008-09-17 0:24 ` Andi Kleen
2008-09-17 19:20 ` FUJITA Tomonori
2008-09-18 18:20 ` Andi Kleen
2008-09-18 22:15 ` FUJITA Tomonori
2008-09-19 0:44 ` Andi Kleen
2008-09-22 19:12 ` FUJITA Tomonori
2008-09-22 20:35 ` Andi Kleen
2008-09-23 4:02 ` FUJITA Tomonori
2008-09-17 10:43 ` Ingo Molnar
2008-09-18 18:25 ` Andi Kleen
2008-09-16 15:52 ` Joerg Roedel
2008-09-16 16:20 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080916134335.GC25711@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=joerg.roedel@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox