From: Ingo Molnar <mingo@elte.hu>
To: Yinghai Lu <yhlu.kernel@gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/6] pci: using printk(KERN_PCI v3
Date: Wed, 17 Sep 2008 10:35:06 +0200 [thread overview]
Message-ID: <20080917083506.GA24035@elte.hu> (raw)
In-Reply-To: <1221640067-24389-4-git-send-email-yhlu.kernel@gmail.com>
* Yinghai Lu <yhlu.kernel@gmail.com> wrote:
> - printk(KERN_DEBUG "PCI: %s reg %x 64bit mmio: [%llx, %llx]\n",
> + printk(KERN_DEBUG KERN_PCI
> + "PCI: %s reg %x 64bit mmio: [%llx, %llx]\n",
i think we should aim to make the common usage of this facility as easy
and short as possible. That means that i think the right line is:
+ printk(KERN_PCI
+ "PCI: %s reg %x 64bit mmio: [%llx, %llx]\n",
as that is the shortest form. KERN_PCI should imply whatever
common-sense default. It should still make sense to specify KERN_FOO
KERN_PCI, to override that default.
Ingo
next prev parent reply other threads:[~2008-09-17 8:35 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-17 8:27 [PATCH 0/6] loglevel=pci:8,acpi:8,apic=8 support v6 Yinghai Lu
2008-09-17 8:27 ` [PATCH 1/6] add DEFINE_LOGLEVEL_SETUP v7 Yinghai Lu
2008-09-17 8:27 ` [PATCH 2/6] pci: add KERN_PCI Yinghai Lu
2008-09-17 8:27 ` [PATCH 3/6] pci: using printk(KERN_PCI v3 Yinghai Lu
2008-09-17 8:35 ` Ingo Molnar [this message]
2008-09-17 8:41 ` Yinghai Lu
2008-09-17 10:11 ` Robert Richter
2008-09-17 16:25 ` Yinghai Lu
2008-09-17 22:28 ` Bjorn Helgaas
2008-09-17 23:03 ` Yinghai Lu
2008-09-17 8:27 ` [PATCH 4/6] acpi: add KERN_ACPI v3 Yinghai Lu
2008-09-17 8:27 ` [PATCH 5/6] apci: dump slit with printk(KERN_ACPI...) Yinghai Lu
2008-09-17 18:19 ` Marcin Slusarz
2008-09-17 18:28 ` Yinghai Lu
2008-09-17 18:56 ` Marcin Slusarz
2008-09-17 8:27 ` [PATCH 6/6] x86: add KERN_APIC Yinghai Lu
2008-09-17 8:38 ` Ingo Molnar
2008-09-17 8:45 ` Yinghai Lu
2008-09-17 8:52 ` Ingo Molnar
2008-09-17 12:08 ` Frans Pop
2008-09-17 16:30 ` Yinghai Lu
2008-09-17 8:55 ` [PATCH 0/6] loglevel=pci:8,acpi:8,apic=8 support v6 Andrew Morton
2008-09-17 9:27 ` Ingo Molnar
2008-09-17 18:46 ` Jason Baron
2008-09-17 19:25 ` H. Peter Anvin
2008-09-18 10:57 ` Ingo Molnar
2008-09-18 15:36 ` H. Peter Anvin
2008-09-18 15:50 ` Jason Baron
2008-09-18 15:57 ` H. Peter Anvin
2008-09-18 16:19 ` Jason Baron
2008-09-18 18:39 ` H. Peter Anvin
2008-09-18 19:06 ` Yinghai Lu
-- strict thread matches above, loose matches on Subject: below --
2008-09-17 7:10 [PATCH 0/6] loglevel=pci:8,acpi:8,apic=8 support v5 Yinghai Lu
2008-09-17 7:10 ` [PATCH 3/6] pci: using printk(KERN_PCI v3 Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080917083506.GA24035@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=yhlu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox