Re: [RFC v5][PATCH 2/8] General infrastructure for checkpoint restart

Dave Hansen
2008-09-15T18:01:11Z

On Sat, 2008-09-13 at 19:06 -0400, Oren Laadan wrote:
>
> +
> +struct cr_ctx *cr_ctx_alloc(pid_t pid, int fd, unsigned long flags)
> +{
> + struct cr_ctx *ctx;
> +
> + ctx = kzalloc(sizeof(*ctx), GFP_KERNEL);
> + if (!ctx)
> + return ERR_PTR(-ENOMEM);
> +
> + ctx->file = fget(fd);
> + if (!ctx->file) {
> + cr_ctx_free(ctx);
> + return ERR_PTR(-EBADF);
> + }
> +
> + ctx->hbuf = (void *) __get_free_pages(GFP_KERNEL, CR_HBUF_ORDER);
> + if (!ctx->hbuf) {
> + cr_ctx_free(ctx);
> + return ERR_PTR(-ENOMEM);
> + }

Could you explain why you're not using the slab here?

-- Dave