From: Alex Chiang <achiang@hp.com>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Yinghai Lu <yhlu.kernel@gmail.com>, Ingo Molnar <mingo@elte.hu>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, bjorn.helgaas@hp.com
Subject: Re: [PATCH 3/5] pci: using pci_printk
Date: Wed, 17 Sep 2008 15:43:06 -0600 [thread overview]
Message-ID: <20080917214305.GA2222@ldl.fc.hp.com> (raw)
In-Reply-To: <20080916102052.GD21012@x200.localdomain>
* Alexey Dobriyan <adobriyan@gmail.com>:
> On Tue, Sep 16, 2008 at 01:52:52AM -0700, Yinghai Lu wrote:
> > --- linux-2.6.orig/drivers/pci/probe.c
> > +++ linux-2.6/drivers/pci/probe.c
> > @@ -304,7 +304,7 @@ static int __pci_read_base(struct pci_de
>
> > - printk(KERN_DEBUG "PCI: %s reg %x 64bit mmio: [%llx, %llx]\n",
> > + pci_printk(KERN_LOG_DEBUG, KERN_DEBUG "PCI: %s reg %x 64bit mmio: [%llx, %llx]\n",
> ^^^^^^^^^^^^^^^^^^^^^^^^^^
> Brilliant, simply brilliant!
Yeah, that's ugly.
> Printk haters club is definitely creative, no questions.
Bjorn might have some useful advice here.
Also, didn't we recently get all the PCI printk output to
resemble what lspci shows us?
/ac
next prev parent reply other threads:[~2008-09-17 21:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-16 8:52 [PATCH 1/5] add DEFINE_LOGLEVEL_SETUP v2 Yinghai Lu
2008-09-16 8:52 ` [PATCH 2/5] pci: add pci_printk v2 Yinghai Lu
2008-09-16 8:52 ` [PATCH 3/5] pci: using pci_printk Yinghai Lu
2008-09-16 10:20 ` Alexey Dobriyan
2008-09-16 17:18 ` Robert Richter
2008-09-17 21:43 ` Alex Chiang [this message]
2008-09-16 8:52 ` [PATCH 4/5] acpi: add acpi_printk Yinghai Lu
2008-09-16 8:52 ` [PATCH 5/5] apci: dump slit v3 Yinghai Lu
2008-09-16 10:13 ` Cyrill Gorcunov
-- strict thread matches above, loose matches on Subject: below --
2008-09-16 18:01 [PATCH 0/5] loglevel=pci:7,acpi:6 support Yinghai Lu
2008-09-16 18:01 ` [PATCH 3/5] pci: using pci_printk Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080917214305.GA2222@ldl.fc.hp.com \
--to=achiang@hp.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=bjorn.helgaas@hp.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=yhlu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox