[PATCH] UIO: Resend: Change driver name of uio_pdrv

[PATCH] UIO: Resend: Change driver name of uio_pdrv

[Hans J. Koch]

The patch below was already discussed and accepted:
http://lkml.org/lkml/2008/7/7/409

It somehow got lost (probably because I forgot it when I sent my queue
to Greg...). So, here it is again:

-------------8<------------------------

The generic UIO platform device driver should be given a unique driver ID and
not just "uio". This is especially important since we now have a similar driver
named uio_pdrv_genirq. Currently, there's no user of this driver in the
mainline kernel.

Signed-off-by: Hans J. Koch <hjk@linutronix.de>
---
 drivers/uio/uio_pdrv.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-2.6.26-rc/drivers/uio/uio_pdrv.c
===================================================================
--- linux-2.6.26-rc.orig/drivers/uio/uio_pdrv.c	2008-07-07 23:57:44.000000000 +0200
+++ linux-2.6.26-rc/drivers/uio/uio_pdrv.c	2008-07-07 23:58:26.000000000 +0200
@@ -12,7 +12,7 @@
 #include <linux/uio_driver.h>
 #include <linux/stringify.h>
 
-#define DRIVER_NAME "uio"
+#define DRIVER_NAME "uio_pdrv"
 
 struct uio_platdata {
 	struct uio_info *uioinfo;

Re: [PATCH] UIO: Resend: Change driver name of uio_pdrv

[Uwe Kleine-König]

Hello Hans,

[Added Magnus Damm (= author of uio_pdrv_genirq) to Cc:]

On Thu, Sep 18, 2008 at 11:03:07PM +0200, Hans J. Koch wrote:
> The patch below was already discussed and accepted:
> http://lkml.org/lkml/2008/7/7/409
> 
> It somehow got lost (probably because I forgot it when I sent my queue
> to Greg...). So, here it is again:
> 
> -------------8<------------------------
> 
> The generic UIO platform device driver should be given a unique driver ID and
> not just "uio". This is especially important since we now have a similar driver
> named uio_pdrv_genirq. Currently, there's no user of this driver in the
> mainline kernel.
I want to suggest to rename uio_pdrv_genirq to uio_genirq instead.  In
my eyes this would be more clear.  IMHO the pdrv suffix doesn't yield
more clearity because it is only used in a certain namespace---namely
that of platform devices.  So e.g.

	/sys/bus/platform/devices/uio_pdrv.0

isn't any better than

	/sys/bus/platform/devices/uio.0

.  Looking at the name of other platform drivers using

	git grep -E '_pdrv(_.*)?"' 

I get three false positives[1] and uio_pdrv_genirq (driver and some
users in arch/sh/kernel/cpu/sh4a/setup-sh7343.c).  So the _pdrv suffix
doesn't seem very common.

Just my 0.02€

Best regards
Uwe

[1] in drivers/scsi/megaraid.c

Re: [PATCH] UIO: Resend: Change driver name of uio_pdrv

[Hans J. Koch]

On Fri, Sep 19, 2008 at 09:40:34AM +0200, Uwe Kleine-König wrote:
> Hello Hans,
> 
> [Added Magnus Damm (= author of uio_pdrv_genirq) to Cc:]
> 
> On Thu, Sep 18, 2008 at 11:03:07PM +0200, Hans J. Koch wrote:
> > The patch below was already discussed and accepted:
> > http://lkml.org/lkml/2008/7/7/409
> > 
> > It somehow got lost (probably because I forgot it when I sent my queue
> > to Greg...). So, here it is again:
> > 
> > -------------8<------------------------
> > 
> > The generic UIO platform device driver should be given a unique driver ID and
> > not just "uio". This is especially important since we now have a similar driver
> > named uio_pdrv_genirq. Currently, there's no user of this driver in the
> > mainline kernel.
> I want to suggest to rename uio_pdrv_genirq to uio_genirq instead.  In
> my eyes this would be more clear.  IMHO the pdrv suffix doesn't yield
> more clearity because it is only used in a certain namespace---namely
> that of platform devices.  So e.g.
> 
> 	/sys/bus/platform/devices/uio_pdrv.0
> 
> isn't any better than
> 
> 	/sys/bus/platform/devices/uio.0

Well, I just want to avoid using the generic "uio" identifier for a
single driver. A sysfs entry like this last one looks like a kind of
"standard way" how a UIO platform device driver should be done. I'd like
to avoid that impression. It can be "uio_pdrv" or "uio_pdrv_genirq", but
there's no standard "uio" way of handling platform devices.

> 
> .  Looking at the name of other platform drivers using
> 
> 	git grep -E '_pdrv(_.*)?"' 
> 
> I get three false positives[1] and uio_pdrv_genirq (driver and some
> users in arch/sh/kernel/cpu/sh4a/setup-sh7343.c).  So the _pdrv suffix
> doesn't seem very common.

I don't really understand what you mean here.

> 
> Just my 0.02€

Thanks,
Hans

Re: [PATCH] UIO: Resend: Change driver name of uio_pdrv

[Uwe Kleine-König]

Hello,

On Mon, Sep 22, 2008 at 10:08:36PM +0200, Hans J. Koch wrote:
> On Fri, Sep 19, 2008 at 09:40:34AM +0200, Uwe Kleine-König wrote:
> > Hello Hans,
> > 
> > [Added Magnus Damm (= author of uio_pdrv_genirq) to Cc:]
Note:  Magnus' address seems to be wrong.  I don't know a working one.

> > > The generic UIO platform device driver should be given a unique driver ID and
> > > not just "uio". This is especially important since we now have a similar driver
> > > named uio_pdrv_genirq. Currently, there's no user of this driver in the
> > > mainline kernel.
> > I want to suggest to rename uio_pdrv_genirq to uio_genirq instead.  In
> > my eyes this would be more clear.  IMHO the pdrv suffix doesn't yield
> > more clearity because it is only used in a certain namespace---namely
> > that of platform devices.  So e.g.
> > 
> > 	/sys/bus/platform/devices/uio_pdrv.0
> > 
> > isn't any better than
> > 
> > 	/sys/bus/platform/devices/uio.0
> 
> Well, I just want to avoid using the generic "uio" identifier for a
> single driver. A sysfs entry like this last one looks like a kind of
> "standard way" how a UIO platform device driver should be done.
I wonder that you don't have this impression with "uio_pdrv".

>                                                                 I'd like
> to avoid that impression. It can be "uio_pdrv" or "uio_pdrv_genirq", but
> there's no standard "uio" way of handling platform devices.
I thought the driver in discussion is kind of a standard way to create a
platform driver using uio.
(At least you called it "generic UIO platform device driver" above :-)

> > 
> > .  Looking at the name of other platform drivers using
> > 
> > 	git grep -E '_pdrv(_.*)?"' 
> > 
> > I get three false positives[1] and uio_pdrv_genirq (driver and some
> > users in arch/sh/kernel/cpu/sh4a/setup-sh7343.c).  So the _pdrv suffix
> > doesn't seem very common.
> 
> I don't really understand what you mean here.
I tried to point out that uio_pdrv_genirq is (probably) the only
platform driver that has _pdrv in its name.

Best regards
Uwe

patch uio-change-driver-name-of-uio_pdrv.patch added to gregkh-2.6 tree

[gregkh]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 1618 bytes --]


This is a note to let you know that I've just added the patch titled

    Subject: UIO: Change driver name of uio_pdrv

to my gregkh-2.6 tree.  Its filename is

    uio-change-driver-name-of-uio_pdrv.patch

This tree can be found at 
    http://www.kernel.org/pub/linux/kernel/people/gregkh/gregkh-2.6/patches/


>From hjk@linutronix.de  Tue Sep 23 15:59:56 2008
From: "Hans J. Koch" <hjk@linutronix.de>
Date: Thu, 18 Sep 2008 23:03:07 +0200
Subject: UIO: Change driver name of uio_pdrv
To: Greg KH <gregkh@suse.de>
Cc: Uwe Kleine-König <ukleinek@strlen.de>, LKML <linux-kernel@vger.kernel.org>
Message-ID: <20080918210306.GC2991@local>
Content-Disposition: inline


The generic UIO platform device driver should be given a unique driver ID and
not just "uio". This is especially important since we now have a similar driver
named uio_pdrv_genirq. Currently, there's no user of this driver in the
mainline kernel.

Signed-off-by: Hans J. Koch <hjk@linutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

---
 drivers/uio/uio_pdrv.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/uio/uio_pdrv.c
+++ b/drivers/uio/uio_pdrv.c
@@ -12,7 +12,7 @@
 #include <linux/uio_driver.h>
 #include <linux/stringify.h>
 
-#define DRIVER_NAME "uio"
+#define DRIVER_NAME "uio_pdrv"
 
 struct uio_platdata {
 	struct uio_info *uioinfo;


Patches currently in gregkh-2.6 which might be from hjk@linutronix.de are

bad/uio-irq.patch
driver-core/uio-add-alignment-warnings-for-uio-mem.patch
driver-core/uio-add-automata-sercos3-pci-card-support.patch
driver-core/uio-change-driver-name-of-uio_pdrv.patch