From: Ingo Molnar <mingo@elte.hu>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: "Maciej W. Rozycki" <macro@linux-mips.org>,
Yinghai Lu <yhlu.kernel@gmail.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -tip/master] x86: io-apic - restore_IO_APIC_setup NULL pointer quick fix
Date: Fri, 19 Sep 2008 10:05:20 +0200 [thread overview]
Message-ID: <20080919080520.GA19491@elte.hu> (raw)
In-Reply-To: <20080918193757.GB7294@lenovo>
* Cyrill Gorcunov <gorcunov@gmail.com> wrote:
> Check if memory was granted first - we don't like NULL deref.
> It's a *quick* fix. Actually it's better to hadle this error
> at moment of memory allocation. It's save_mask_IO_APIC_setup
> route who allocates this memory (just for the record).
>
> Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
> ---
>
> I'll handle this in _normal_ way tomorrow. Please review.
ok, i've applied the quick fix to tip/master - the patch will drop from
there on the next integration run.
Ingo
next prev parent reply other threads:[~2008-09-19 8:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-18 19:37 [PATCH -tip/master] x86: io-apic - restore_IO_APIC_setup NULL pointer quick fix Cyrill Gorcunov
2008-09-19 8:05 ` Ingo Molnar [this message]
2008-09-19 10:00 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080919080520.GA19491@elte.hu \
--to=mingo@elte.hu \
--cc=gorcunov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=macro@linux-mips.org \
--cc=yhlu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox