From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756562AbYISKAZ (ORCPT ); Fri, 19 Sep 2008 06:00:25 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751089AbYISKAM (ORCPT ); Fri, 19 Sep 2008 06:00:12 -0400 Received: from fg-out-1718.google.com ([72.14.220.159]:38687 "EHLO fg-out-1718.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750908AbYISKAK (ORCPT ); Fri, 19 Sep 2008 06:00:10 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=Ts8onAfwXkVnbiajiodpayv3b54VUn1ygpJ5tceMERz1smN/IsGhXoQAI7lh/qBJAo xjtWs2qZ6ZV2Bx++uPGQ01xuL6E32InbKkVNgVXXN0xd/HNUdFbJCFJy4N496PJop416 jfXxsmxiaufE2i1wo0jxzow4r2ne0PhBqPEYU= Date: Fri, 19 Sep 2008 14:00:09 +0400 From: Cyrill Gorcunov To: Ingo Molnar Cc: "Maciej W. Rozycki" , Yinghai Lu , LKML Subject: Re: [PATCH -tip/master] x86: io-apic - restore_IO_APIC_setup NULL pointer quick fix Message-ID: <20080919100009.GC7222@lenovo> References: <20080918193757.GB7294@lenovo> <20080919080520.GA19491@elte.hu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080919080520.GA19491@elte.hu> User-Agent: Mutt/1.5.17+20080114 (2008-01-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [Ingo Molnar - Fri, Sep 19, 2008 at 10:05:20AM +0200] | | * Cyrill Gorcunov wrote: | | > Check if memory was granted first - we don't like NULL deref. | > It's a *quick* fix. Actually it's better to hadle this error | > at moment of memory allocation. It's save_mask_IO_APIC_setup | > route who allocates this memory (just for the record). | > | > Signed-off-by: Cyrill Gorcunov | > --- | > | > I'll handle this in _normal_ way tomorrow. Please review. | | ok, i've applied the quick fix to tip/master - the patch will drop from | there on the next integration run. | | Ingo | thanks Ingo, it seems there memory leak too. Handling... - Cyrill -